Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Backend for AVX512Backend #491

Conversation

spapinistarkware
Copy link
Collaborator

@spapinistarkware spapinistarkware commented Mar 16, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 93.43%. Comparing base (6a9223d) to head (504018a).

Files Patch % Lines
src/core/backend/avx512/accumulation.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                               Coverage Diff                               @@
##           spapini/03-16-make_prove_generic_in_backend     #491      +/-   ##
===============================================================================
- Coverage                                        93.50%   93.43%   -0.08%     
===============================================================================
  Files                                               63       64       +1     
  Lines                                             7881     7903      +22     
  Branches                                          7881     7903      +22     
===============================================================================
+ Hits                                              7369     7384      +15     
- Misses                                             454      461       +7     
  Partials                                            58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


src/core/backend/avx512/mod.rs line 139 at r4 (raw file):

impl SecureColumn<AVX512Backend> {
    pub fn packed_at(&self, vec_index: usize) -> PackedQM31 {

Why removed the Safety and unsafe?

@spapinistarkware spapinistarkware force-pushed the spapini/03-16-make_prove_generic_in_backend branch from 42f9f4c to 6a9223d Compare April 3, 2024 06:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-16-implement_backend_for_avx512backend branch from 0a61546 to 504018a Compare April 3, 2024 06:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-16-make_prove_generic_in_backend branch 2 times, most recently from 15792de to d6c6c07 Compare April 3, 2024 06:49
@spapinistarkware spapinistarkware mentioned this pull request Apr 3, 2024
@spapinistarkware spapinistarkware force-pushed the spapini/03-16-make_prove_generic_in_backend branch 2 times, most recently from 2a6c1c1 to 2247dbf Compare April 3, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants