-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Backend for AVX512Backend #491
Implement Backend for AVX512Backend #491
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spapinistarkware and the rest of your teammates on |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spapini/03-16-make_prove_generic_in_backend #491 +/- ##
===============================================================================
- Coverage 93.50% 93.43% -0.08%
===============================================================================
Files 63 64 +1
Lines 7881 7903 +22
Branches 7881 7903 +22
===============================================================================
+ Hits 7369 7384 +15
- Misses 454 461 +7
Partials 58 58 ☔ View full report in Codecov by Sentry. |
3c9f330
to
364984c
Compare
f21e77e
to
12ade2f
Compare
364984c
to
05f6703
Compare
12ade2f
to
a8014d1
Compare
0e6f2ac
to
42f9f4c
Compare
be0ce1c
to
0a61546
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
src/core/backend/avx512/mod.rs
line 139 at r4 (raw file):
impl SecureColumn<AVX512Backend> { pub fn packed_at(&self, vec_index: usize) -> PackedQM31 {
Why removed the Safety and unsafe?
42f9f4c
to
6a9223d
Compare
0a61546
to
504018a
Compare
15792de
to
d6c6c07
Compare
2a6c1c1
to
2247dbf
Compare
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)