-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVX quotients #488
AVX quotients #488
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spapinistarkware and the rest of your teammates on Graphite |
Your org has enabled the Graphite merge queue for merging into devAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
7093a6d
to
3648a4b
Compare
74e5964
to
2d000a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 13 files reviewed, all discussions resolved (waiting on @spapinistarkware)
da75cb6
to
4819acf
Compare
99edb32
to
1bc7cc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 9 files at r10, 2 of 2 files at r11, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
src/core/backend/avx512/mod.rs
line 154 at r11 (raw file):
} pub fn set_packed(&mut self, vec_index: usize, value: PackedQM31) {
Suggestion:
pub unsafe fn set_packed
Suggestion: pub unsafe fn packed_at |
4819acf
to
473669c
Compare
1bc7cc4
to
a12c1c9
Compare
473669c
to
282879e
Compare
a12c1c9
to
41f45ca
Compare
282879e
to
3cb8a76
Compare
41f45ca
to
2879bc5
Compare
cc4a502
to
54412ea
Compare
2879bc5
to
4b23127
Compare
54412ea
to
774267b
Compare
4b23127
to
195f7e6
Compare
774267b
to
ff6eb6e
Compare
195f7e6
to
49de31d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 13 files reviewed, 2 unresolved discussions (waiting on @andrewmilson)
src/core/backend/avx512/mod.rs
line 139 at r11 (raw file):
impl SecureColumn<AVX512Backend> { pub fn packed_at(&self, vec_index: usize) -> PackedQM31 {
It's not a part of this PR now. This can be done independently in another PR.
src/core/backend/avx512/mod.rs
line 154 at r11 (raw file):
} pub fn set_packed(&mut self, vec_index: usize, value: PackedQM31) {
Same
49de31d
to
e63745d
Compare
Merge activity
|
e63745d
to
d8ee82f
Compare
This change is