Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVX quotients #488

Merged
merged 1 commit into from
Apr 3, 2024
Merged

AVX quotients #488

merged 1 commit into from
Apr 3, 2024

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Mar 15, 2024

This change is Reviewable

Copy link
Contributor Author

spapinistarkware commented Mar 15, 2024

Copy link

graphite-app bot commented Mar 15, 2024

Your org has enabled the Graphite merge queue for merging into dev

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 4 of 13 files reviewed, all discussions resolved (waiting on @spapinistarkware)

Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 9 files at r10, 2 of 2 files at r11, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


src/core/backend/avx512/mod.rs line 154 at r11 (raw file):

    }

    pub fn set_packed(&mut self, vec_index: usize, value: PackedQM31) {

Suggestion:

pub unsafe fn set_packed

@andrewmilson
Copy link
Contributor

src/core/backend/avx512/mod.rs line 139 at r11 (raw file):

impl SecureColumn<AVX512Backend> {
    pub fn packed_at(&self, vec_index: usize) -> PackedQM31 {

Suggestion:

pub unsafe fn packed_at

@spapinistarkware spapinistarkware force-pushed the spapini/03-15-clean_up_fri_quotients branch from 4819acf to 473669c Compare April 3, 2024 06:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-clean_up_fri_quotients branch from 473669c to 282879e Compare April 3, 2024 06:45
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-clean_up_fri_quotients branch from 282879e to 3cb8a76 Compare April 3, 2024 06:49
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-clean_up_fri_quotients branch 2 times, most recently from cc4a502 to 54412ea Compare April 3, 2024 10:55
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-clean_up_fri_quotients branch from 54412ea to 774267b Compare April 3, 2024 11:46
@spapinistarkware spapinistarkware mentioned this pull request Apr 3, 2024
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-clean_up_fri_quotients branch from 774267b to ff6eb6e Compare April 3, 2024 12:46
Copy link
Contributor Author

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 13 files reviewed, 2 unresolved discussions (waiting on @andrewmilson)


src/core/backend/avx512/mod.rs line 139 at r11 (raw file):

impl SecureColumn<AVX512Backend> {
    pub fn packed_at(&self, vec_index: usize) -> PackedQM31 {

It's not a part of this PR now. This can be done independently in another PR.


src/core/backend/avx512/mod.rs line 154 at r11 (raw file):

    }

    pub fn set_packed(&mut self, vec_index: usize, value: PackedQM31) {

Same

@spapinistarkware spapinistarkware changed the base branch from spapini/03-15-clean_up_fri_quotients to spapini/03-22-remove_old_merkle April 3, 2024 13:09
Copy link
Contributor Author

spapinistarkware commented Apr 3, 2024

Merge activity

@spapinistarkware spapinistarkware changed the base branch from spapini/03-22-remove_old_merkle to dev April 3, 2024 15:19
@spapinistarkware spapinistarkware merged commit 7dedf53 into dev Apr 3, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants