DomainAccumulator allows accumulating a row at once

[spapinistarkware]

This change is 

[graphite-app]

Your org has enabled the Graphite merge queue for merging into dev

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

[spapinistarkware]

• parallel wide fib test #511
• Evaluation oods once #496
• Reuse commitment evaluation #495
• Use precomputed twiddles #494
• Add measurement logs #493
• WideFib test with AVX Backend #492
• Implement Backend for AVX512Backend #491
• Make prove() generic in Backend #490
• CommitmentSchemeProver generic in backend #489
• AVX quotients #488
• Clean up fri quotients #486
• Save inverse on quotient numerator #484
• Commitment Scheme evaluation per size #483
• Separate commitment prover and verifier to modules #482
• QuotientOps #481
• DomainAccumulator allows accumulating a row at once #480 👈
• Rename evalaution.rs to accumulaion.rs #479
• Move SecureColumn #478
• Use only canonic domains #463
• Revert "integrated batch inverse in fib cpu (#448)" #477
• FRI in Commitment Scheme #476
• Field debug implementations #501
• CommitmentScheme utils #500
• Air with dyn component #487
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.06%. Comparing base (3524e6b) to head (760ccc2).

Files	Patch %	Lines
src/core/air/accumulation.rs	94.73%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #480      +/-   ##
==========================================
+ Coverage   95.03%   95.06%   +0.02%     
==========================================
  Files          61       61              
  Lines        9123     9130       +7     
  Branches     9123     9130       +7     
==========================================
+ Hits         8670     8679       +9     
+ Misses        396      393       -3     
- Partials       57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)

---

src/core/air/accumulation.rs line 107 at r3 (raw file):

            .unwrap_or_else(|e| panic!("invalid log_sizes: {}", e))
            .map(|c| ColumnAccumulator {
                random_coeff_pow: self.random_coeff,

I don't understand this, seems that it always get the same element.
Why not give the ColumnAccumulator the correct pow in advance?

(I thought this change reduces the need of exposing the random coeff from this struct)

Code quote:

random_coeff_pow: self.random_coeff,

---

src/core/air/accumulation.rs line 112 at r3 (raw file):

        for i in 0..N {
            res[i].random_coeff_pow = self.random_coeff.pow(n_cols_per_size[i].1 as u128);
        }

Don't we want to calculate the powers more efficiently?

Code quote:

        for i in 0..N {
            res[i].random_coeff_pow = self.random_coeff.pow(n_cols_per_size[i].1 as u128);
        }

[spapinistarkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

src/core/air/accumulation.rs line 107 at r3 (raw file):

Previously, shaharsamocha7 wrote…

I don't understand this, seems that it always get the same element.
Why not give the ColumnAccumulator the correct pow in advance?

(I thought this change reduces the need of exposing the random coeff from this struct)

Done.

---

src/core/air/accumulation.rs line 112 at r3 (raw file):

Previously, shaharsamocha7 wrote…

Don't we want to calculate the powers more efficiently?

Done.

[shaharsamocha7]

Reviewed 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[spapinistarkware]

Merge activity

• Mar 24, 9:16 AM EDT: @spapinistarkware started a stack merge that includes this pull request via Graphite.
• Mar 24, 9:17 AM EDT: @spapinistarkware merged this pull request with Graphite.