Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommitmentSchemeProver generic in backend #489

Conversation

spapinistarkware
Copy link
Collaborator

@spapinistarkware spapinistarkware commented Mar 16, 2024

This change is Reviewable

Copy link
Collaborator Author

spapinistarkware commented Mar 16, 2024

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.44%. Comparing base (9d91b8a) to head (5a50691).

❗ Current head 5a50691 differs from pull request most recent head 3659df9. Consider uploading reports for the commit 3659df9 to get more accurate results

Files Patch % Lines
src/core/backend/avx512/mod.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #489      +/-   ##
==========================================
- Coverage   93.44%   93.44%   -0.01%     
==========================================
  Files          63       63              
  Lines        8289     8287       -2     
  Branches     8289     8287       -2     
==========================================
- Hits         7746     7744       -2     
  Misses        481      481              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from 9ccea91 to 013d95c Compare March 28, 2024 09:44
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from 013d95c to fe5fc4b Compare April 3, 2024 06:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from fe5fc4b to 2820b53 Compare April 3, 2024 06:45
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from 2820b53 to d68f9c8 Compare April 3, 2024 06:49
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from d68f9c8 to 1a09f8c Compare April 3, 2024 10:55
@spapinistarkware spapinistarkware changed the base branch from spapini/03-15-avx_quotients to Fri_AVX_ops April 3, 2024 11:46
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from 1a09f8c to a1393b7 Compare April 3, 2024 11:46
@spapinistarkware spapinistarkware mentioned this pull request Apr 3, 2024
@spapinistarkware spapinistarkware force-pushed the Fri_AVX_ops branch 3 times, most recently from 6fb0019 to efe300a Compare April 3, 2024 12:46
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from a1393b7 to 573b59e Compare April 3, 2024 12:47
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from 573b59e to 967baeb Compare April 3, 2024 12:55
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from 967baeb to d6901e7 Compare April 3, 2024 13:09
@spapinistarkware spapinistarkware force-pushed the Fri_AVX_ops branch 2 times, most recently from 1b98a0d to 9410eb1 Compare April 4, 2024 07:36
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from d6901e7 to 5a50691 Compare April 4, 2024 09:47
@spapinistarkware spapinistarkware changed the base branch from Fri_AVX_ops to dev April 4, 2024 09:47
@spapinistarkware spapinistarkware force-pushed the spapini/03-15-commitmentschemeprover_generic_in_backend branch from 5a50691 to 3659df9 Compare April 4, 2024 09:52
Copy link
Collaborator Author

spapinistarkware commented Apr 4, 2024

Merge activity

@spapinistarkware spapinistarkware merged commit 8046f4f into dev Apr 4, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants