Separate commitment prover and verifier to modules

[spapinistarkware]

This change is 

[graphite-app]

Your org has enabled the Graphite merge queue for merging into dev

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

[spapinistarkware]

• parallel wide fib test #511
• Evaluation oods once #496
• Reuse commitment evaluation #495
• Use precomputed twiddles #494
• Add measurement logs #493
• WideFib test with AVX Backend #492
• Implement Backend for AVX512Backend #491
• Make prove() generic in Backend #490
• CommitmentSchemeProver generic in backend #489
• AVX quotients #488
• Clean up fri quotients #486
• Save inverse on quotient numerator #484
• Commitment Scheme evaluation per size #483
• Separate commitment prover and verifier to modules #482 👈
• QuotientOps #481
• DomainAccumulator allows accumulating a row at once #480
• Rename evalaution.rs to accumulaion.rs #479
• Move SecureColumn #478
• Use only canonic domains #463
• Revert "integrated batch inverse in fib cpu (#448)" #477
• FRI in Commitment Scheme #476
• Field debug implementations #501
• CommitmentScheme utils #500
• Air with dyn component #487
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 98.67550% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 95.09%. Comparing base (20412e4) to head (c69d9da).

Files	Patch %	Lines
src/core/commitment_scheme/verifier.rs	97.84%	2 Missing and 1 partial ⚠️
src/core/commitment_scheme/prover.rs	99.38%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #482   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files          62       63    +1     
  Lines        9195     9195           
  Branches     9195     9195           
=======================================
  Hits         8744     8744           
  Misses        393      393           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alonh5]

Reviewed 3 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)

---

src/core/commitment_scheme/prover.rs line 6 at r2 (raw file):

//! Note: This implementation is not really a polynomial commitment scheme, because we are not in
//! the unique decoding regime. This is enough for a STARK proof though, where we onyl want to imply
//! the existence of such polynomials, and re ok with having a small decoding list.

Move to mod.rs?

Code quote:

//! Implements a FRI polynomial commitment scheme.
//! This is a protocol where the prover can commit on a set of polynomials and then prove their
//! opening on a set of points.
//! Note: This implementation is not really a polynomial commitment scheme, because we are not in
//! the unique decoding regime. This is enough for a STARK proof though, where we onyl want to imply
//! the existence of such polynomials, and re ok with having a small decoding list.

---

src/core/commitment_scheme/verifier.rs line 27 at r2 (raw file):

type ProofChannel = Blake2sChannel;

/// The verifier side of a FRI polynomial commitment scheme. See [self].

Modify this.

Code quote:

See [self]

[spapinistarkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

src/core/commitment_scheme/prover.rs line 6 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Move to mod.rs?

Done.

---

src/core/commitment_scheme/verifier.rs line 27 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Modify this.

Done.

[alonh5]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)