forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 0
DEP-11967 cookie sync prebid.js integration #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IlliaMil
wants to merge
6
commits into
master
Choose a base branch
from
DEP-11967-Cookie-Sync-Prebid.js-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
66101f3
Add Start.io User ID submodule with tests and documentation
IlliaMil 6ff92f8
Merge branch 'refs/heads/master' into DEP-11967-Cookie-Sync-Prebid.js…
IlliaMil 7db3472
Update Start.io User ID module to ensure callbacks and AJAX requests …
IlliaMil 8bbf781
Remove storage-related functionality from Start.io ID submodule and a…
IlliaMil 4f2aee9
Add iframe-based user syncing to Start.io Bid Adapter with consent pa…
IlliaMil d6e0c98
Simplify Start.io ID module by removing storage-related parameters an…
IlliaMil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /** | ||
| * This module adds startio ID support to the User ID module | ||
| * The {@link module:modules/userId} module is required | ||
| * @module modules/startioSystem | ||
| * @requires module:modules/userId | ||
| */ | ||
| import { logError } from '../src/utils.js'; | ||
| import { submodule } from '../src/hook.js'; | ||
| import { ajax } from '../src/ajax.js'; | ||
|
|
||
| const MODULE_NAME = 'startioId'; | ||
| const DEFAULT_ENDPOINT = ''; | ||
|
|
||
| export const startioIdSubmodule = { | ||
| name: MODULE_NAME, | ||
| decode(value) { | ||
| return value && typeof value === 'string' | ||
| ? { 'startioId': value } | ||
| : undefined; | ||
| }, | ||
| getId(config, consentData, storedId) { | ||
| const configParams = (config && config.params) || {}; | ||
| const endpoint = configParams.endpoint || DEFAULT_ENDPOINT; | ||
|
|
||
| if (storedId) { | ||
| return { id: storedId }; | ||
| } | ||
|
|
||
| const resp = function (callback) { | ||
| const callbacks = { | ||
| success: response => { | ||
| let responseId; | ||
| try { | ||
| const responseObj = JSON.parse(response); | ||
| if (responseObj && responseObj.id) { | ||
| responseId = responseObj.id; | ||
| } else { | ||
| logError(`${MODULE_NAME}: Server response missing 'id' field`); | ||
| } | ||
| } catch (error) { | ||
| logError(`${MODULE_NAME}: Error parsing server response`, error); | ||
| } | ||
| callback(responseId); | ||
| }, | ||
| error: error => { | ||
| logError(`${MODULE_NAME}: ID fetch encountered an error`, error); | ||
| callback(); | ||
| } | ||
| }; | ||
| ajax(endpoint, callbacks, undefined, { method: 'GET' }); | ||
| }; | ||
| return { callback: resp }; | ||
| }, | ||
|
|
||
| eids: { | ||
| 'startioId': { | ||
| source: 'start.io', | ||
| atype: 3 | ||
| }, | ||
| } | ||
| }; | ||
|
|
||
| submodule('userId', startioIdSubmodule); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| ## Start.io User ID Submodule | ||
|
|
||
| The Start.io User ID submodule generates and persists a unique user identifier by fetching it from a publisher-supplied endpoint. The ID is stored in both cookies and local storage for subsequent page loads and is made available to other Prebid.js modules via the standard `eids` interface. | ||
|
|
||
| For integration support, contact prebid@start.io. | ||
|
|
||
| ### Prebid Params | ||
|
|
||
| ``` | ||
| pbjs.setConfig({ | ||
| userSync: { | ||
| userIds: [{ | ||
| name: 'startioId' | ||
| }] | ||
| } | ||
| }); | ||
| ``` | ||
|
|
||
| ## Parameter Descriptions for the `userSync` Configuration Section | ||
|
|
||
| The below parameters apply only to the Start.io User ID integration. | ||
|
|
||
| | Param under userSync.userIds[] | Scope | Type | Description | Example | | ||
| | --- | --- | --- | --- | --- | | ||
| | name | Required | String | The name of this module. | `"startioId"` | | ||
|
|
||
| ## Server Response Format | ||
|
|
||
| The endpoint specified in `params.endpoint` must return a JSON response containing an `id` field: | ||
|
|
||
| ``` | ||
| { | ||
| "id": "unique-user-identifier-string" | ||
| } | ||
| ``` | ||
|
|
||
| If the `id` field is missing or the response cannot be parsed, the module logs an error and does not store a value. | ||
|
|
||
| ## How It Works | ||
|
|
||
| 1. On the first page load (no stored ID exists), the module sends a `GET` request to the configured `endpoint`. | ||
| 2. The returned `id` is written to both cookies and local storage (respecting the `storage` configuration). | ||
| 3. On subsequent loads the stored ID is returned directly — no network request is made. | ||
| 4. The ID is exposed to other modules via the extended ID (`eids`) framework with source `start.io` and `atype: 3`. | ||
|
|
||
| ## Notes | ||
|
|
||
| - The `endpoint` parameter is required. The module will log an error and return no ID if it is missing or not a string. | ||
| - Storage defaults to both cookies and local storage when no explicit `storage.type` is provided. The module checks whether each mechanism is available before writing. | ||
| - Cookie expiration is set to `storage.expires` days from the time the ID is first fetched (default 365 days). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding to "consentData":
The standard fields on consentData are:
Do we need add them to our url? @matanarbel-startapp