Refactor URL detection logic to match sites #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dongfengweixiao
commented
Oct 1, 2024
dongfengweixiao
commented
- Change the original if-else chain to iterate through the urlPatterns array
- Each urlPattern object contains pattern and site attributes
- Use regular expressions to test the URL and return the corresponding site name
- Added regular expression matching rules for some additional sites
- Set "Studio Profile" as the default return value for the urlSite().
- Change the original if-else chain to iterate through the urlPatterns array - Each urlPattern object contains pattern and site attributes - Use regular expressions to test the URL and return the corresponding site name - Added regular expression matching rules for some additional sites
DogmaDragon
added a commit
that referenced
this pull request
Oct 14, 2024
Add check to skip unmatched URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.