Skip to content

Conversation

@tdgfrost
Copy link
Contributor

@tdgfrost tdgfrost commented Oct 7, 2024

Addresses two errors when use_eff_mem_path is set to False (to avoid causal_conv1d):

  1. There is a typo at line 233 - currently the class references self.dconv (which doesn't exist) instead of self.d_conv. This gives rise to an attribute missing error.
  2. Assuming I've understood correctly, the original code indexes the post-conv1d tensor incorrectly. For example, if the sequence length were 20 and the post-conv1d tensor has length 23, it is indexed to the last 3 items rather than the first 20.

Original version indexes sequence to the padding, not the sequence length (and has a typo when refering self.dconv instead of self.d_conv).
@tridao tridao merged commit 6b72c12 into state-spaces:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants