Skip to content

Conversation

@ccoulombe
Copy link
Contributor

Added triton as dependency.

Otherwise it fails on import:

$ python -c 'import mamba_ssm'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/coulombc/26517/lib/python3.11/site-packages/mamba_ssm/__init__.py", line 3, in <module>
    from mamba_ssm.ops.selective_scan_interface import selective_scan_fn, mamba_inner_fn
  File "/tmp/coulombc/26517/lib/python3.11/site-packages/mamba_ssm/ops/selective_scan_interface.py", line 16, in <module>
    from mamba_ssm.ops.triton.layer_norm import _layer_norm_fwd
  File "/tmp/coulombc/26517/lib/python3.11/site-packages/mamba_ssm/ops/triton/layer_norm.py", line 16, in <module>
    import triton
ModuleNotFoundError: No module named 'triton'

Added triton as dependency
@ccoulombe ccoulombe changed the title Update pyproject.toml Add triton as dependency Jan 15, 2025
@garrett361
Copy link

garrett361 commented Jan 16, 2025

Seems the triton dependency was recently removed, quite intentionally. I am curious why.

@ccoulombe
Copy link
Contributor Author

@garrett361 Ah thanks I missed that (in the unfortunate habit of so many projects actually missing dependencies..)

@tridao can perhaps shade some light on this ?

@tridao tridao merged commit 0cce0fa into state-spaces:main Jan 18, 2025
@tridao
Copy link
Collaborator

tridao commented Jan 18, 2025

I think I was trying to debug some issue with CI and automatically uploading to PyPI

@tridao
Copy link
Collaborator

tridao commented Jan 18, 2025

Or that pytorch has its own triton package (pytorch-triton) and I was worried having triton as a dependency would conflict with that (i'm still not sure if this is an issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants