Variable syntax update #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
There was a problem hiding this comment.
This was slightly hacky, but no way around it with the way nib is set up currently.
This was referenced Aug 11, 2015
Closed
…ture-proofing per #201
jescalan
force-pushed
the
variable-syntax
branch
from
35e3776 to
85feba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #201
Don't merge this guy until #206 has been merged and we push a release with those updates. (0.4.3).
Putting this here so others can pull down and test, as I pretty much touched everything. Needless to say I spent a lot of time staring at the testing screen.
This proved to me that variables absolutely must start with
$.It's just too hard to decipher whats going on without it, especially variable names that end up being css attributes too.
colorwidthandfont-sizewere SO not my friends.So, it's passing all test and everything looks good in
visual.html. Not really sure how else to test it further without bringing it into a project.I was thinking this needed to get rolled into one big update with "dropping nib", but now I realize we have to do this in steps – also because I have some more features I'd like to add, and want to move forward with the new syntax on all additions.
I'll address next steps in an issue thread.
Thnx!