allow typeof [string|array] in entry point values #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jescalan
reviewed
Dec 14, 2016
lib/config.js
Outdated
| for (let key in res.entry) { | ||
| let value = res.entry[key] | ||
| if (typeof value === 'string') res.entry[key] = Array(value) | ||
| } |
There was a problem hiding this comment.
So you can do res.entry[key] = Array.prototype.concat(res.entry[key]) here to one-line it 😁
jescalan
reviewed
Dec 15, 2016
lib/config.js
Outdated
| // webpack must consume an array for the value in our entry object | ||
| for (let key in res.entry) { | ||
| if (typeof value === 'string') res.entry[key] = Array.prototype.concat(res.entry[key]) | ||
| } |
There was a problem hiding this comment.
Ah sorry you can actually leave out the type check as well, this will leave an array as an array but coerce a string. Also could you add a test for this? 👼 🙇
|
@jescalan everything should be in order here |
|
This looks fantastic. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.