Skip to content

allow typeof [string|array] in entry point values #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2016
Merged

allow typeof [string|array] in entry point values #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ module.exports = class Config {
res.server.middleware.unshift(hygienist(res.server.server.baseDir))
}

// webpack must consume an array for the value in our entry object
for (let key in res.entry) { res.entry[key] = Array.prototype.concat(res.entry[key]) }

// ensure server.watchOptions.ignored is an array (browsersync accepts
// string or array), then push ['node_modules', '.git', outputDir] to make
// sure they're not watched
Expand Down
7 changes: 7 additions & 0 deletions test/app_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,10 @@ test('postcss querystring options', (t) => {
t.truthy(cssLoaderConfig.loader === 'source-loader!postcss-loader?foo=bar')
})
})

test('allows typeof string for entry object\'s value', (t) => {
return compileFixture(t, 'app_config', {entry: { 'js/main': './js/index.js' }})
.then(({res}) => {
t.truthy(Array.isArray(res.stats.compilation.options.entry['js/main']))
})
})