improve column batch addition from getBlobs (#7725)

agnxsh · web-flow · commit 1c55749d4bc5 · 2025-11-13T12:57:57.000+01:00
* improve column batch addition from getBlobs

* review

* add fulu.DataColumnSidecar, why is it redefined for Gloas anyway?

* resolve issues
diff --git a/beacon_chain/nimbus_beacon_node.nim b/beacon_chain/nimbus_beacon_node.nim
@@ -2110,9 +2110,20 @@ proc attemptGetBlobs(node: BeaconNode,
               flat_proof)
             # Send notification to event stream
             # and add these columns to column quarantine
+            let MaxColsPerPut = (node.dag.cfg.NUMBER_OF_COLUMNS.int div 2) + 1
+
+            var batch = newSeqOfCap[ref fulu.DataColumnSidecar](MaxColsPerPut)
+
             for col in recovered_columns:
-              if col.index in node.dataColumnQuarantine[].custodyColumns:
-                node.dataColumnQuarantine[].put(forkyBlck.root, newClone(col))
+              if col.index notin node.dataColumnQuarantine[].custodyColumns:
+                continue
+
+              batch.add(newClone(col))
+              if batch.len == MaxColsPerPut:
+                break
+
+            if batch.len > 0:
+              node.dataColumnQuarantine[].put(forkyBlck.root, batch)
 
 proc onSlotStart(node: BeaconNode, wallTime: BeaconTime,
                  lastSlot: Slot): Future[bool] {.async.} =
