Deprecate --in-process-validators flag and rm related leftovers (#7777)

kdeme · web-flow · commit 7a95ab27c46d · 2025-12-04T16:23:46.000Z
diff --git a/beacon_chain/beacon_node.nim b/beacon_chain/beacon_node.nim
@@ -97,7 +97,6 @@ type
     keymanagerServer*: RestServerRef
     keystoreCache*: KeystoreCacheRef
     eventBus*: EventBus
-    vcProcess*: Process
     requestManager*: RequestManager
     validatorCustody*: ValidatorCustodyRef
     syncManager*: SyncManager[Peer, PeerId]
diff --git a/beacon_chain/conf.nim b/beacon_chain/conf.nim
@@ -563,9 +563,9 @@ type
         name: "debug-long-range-sync".}: LongRangeSyncMode
 
       inProcessValidators* {.
-        desc: "Disable the push model (the beacon node tells a signing process with the private keys of the validators what to sign and when) and load the validators in the beacon node itself"
-        defaultValue: true # the use of the nimbus_signing_process binary by default will be delayed until async I/O over stdin/stdout is developed for the child process.
-        name: "in-process-validators" .}: bool
+        hidden
+        desc: "Deprecated for removal"
+        name: "in-process-validators" .}: Option[bool]
 
       discv5Enabled* {.
         desc: "Enable Discovery v5"
diff --git a/beacon_chain/nimbus_beacon_node.nim b/beacon_chain/nimbus_beacon_node.nim
@@ -2585,11 +2585,6 @@ proc installMessageValidators(node: BeaconNode) =
   node.installLightClientMessageValidators()
 
 proc stop(node: BeaconNode) =
-  if not node.config.inProcessValidators:
-    try:
-      node.vcProcess.close()
-    except Exception as exc:
-      warn "Couldn't close vc process", msg = exc.msg
   try:
     waitFor node.network.stop()
   except CatchableError as exc:
@@ -2869,6 +2864,7 @@ proc doRunBeaconNode(
   ignoreDeprecatedOption web3ForcePolling
   ignoreDeprecatedOption finalizedDepositTreeSnapshot
   ignoreDeprecatedOption finalizedCheckpointBlock
+  ignoreDeprecatedOption inProcessValidators
 
   # Trusted setup is needed for Cancun+ blocks and is shared between threads,
   # so it needs to be initalized from the main thread before anything else tries
diff --git a/docs/the_nimbus_book/src/options.md b/docs/the_nimbus_book/src/options.md
@@ -113,9 +113,6 @@ The following options are available:
      --light-client-data-import-mode  Which classes of light client data to import. Must be one of: none, only-new,
                                full (slow startup), on-demand (may miss validator duties) [=only-new].
      --light-client-data-max-periods  Maximum number of sync committee periods to retain light client data.
-     --in-process-validators   Disable the push model (the beacon node tells a signing process with the private
-                               keys of the validators what to sign and when) and load the validators in the
-                               beacon node itself [=true].
      --discv5                  Enable Discovery v5 [=true].
      --dump                    Write SSZ dumps of blocks and states to data dir [=false].
      --direct-peer             The list of privileged, secure and known peers to connect and maintain the
