Skip to content

Commit db73853

Browse files
committed
Post-rebase fixes.
1 parent c216162 commit db73853

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

beacon_chain/consensus_object_pools/block_quarantine.nim

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -396,6 +396,11 @@ func getColumnless*(
396396
): Opt[ForkedSignedBeaconBlock] =
397397
quarantine.sidecarless.peek(root)
398398

399+
func peekSidecarless*(
400+
quarantine: var Quarantine, root: Eth2Digest
401+
): Opt[ForkedSignedBeaconBlock] =
402+
quarantine.sidecarless.peek(root)
403+
399404
iterator peekSidecarless*(quarantine: Quarantine): ForkedSignedBeaconBlock =
400405
for k, v in quarantine.sidecarless.pairs():
401406
yield v

beacon_chain/gossip_processing/block_processor.nim

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,8 @@ proc storeBackfillBlock(
279279
res
280280
of VerifierError.Duplicate:
281281
res
282+
of VerifierError.MissingSidecars:
283+
res
282284
else:
283285
# Only store side cars after successfully establishing block viability.
284286
self.storeSidecars(sidecarsOpt)
@@ -835,3 +837,5 @@ proc addBlock*(
835837
err(res.error())
836838
of VerifierError.Duplicate:
837839
err(res.error())
840+
of VerifierError.MissingSidecars:
841+
err(res.error())

beacon_chain/sync/sync_overseer2.nim

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1307,14 +1307,10 @@ proc doPeerUpdateRootsSidecars(
13071307
var res: ref ForkedSignedBeaconBlock
13081308
res = overseer.rblockBuffer.getOrDefault(bid.root)
13091309
if isNil(res):
1310-
let qres =
1311-
try:
1312-
newClone overseer.blockQuarantine.sidecarless[bid.root]
1313-
except KeyError:
1314-
nil
1315-
if isNil(qres):
1310+
let qres = overseer.blockQuarantine[].peekSidecarless(bid.root)
1311+
if qres.isNone():
13161312
continue
1317-
res = qres
1313+
res = newClone qres.get()
13181314
res
13191315

13201316
withBlck(signedBlock[]):

0 commit comments

Comments
 (0)