Fix: Mobile MVP UI and feature fixes

ci/Jenkinsfile.android

@@ -63,6 +63,7 @@ pipeline {
     /* Control output the filename */
     APP_TYPE = "${utils.getAppType()}"
     PLATFORM = "android/arm64"
+    MAKEFLAGS = "-j${utils.getProcCount()} V=${params.VERBOSE}"
     QT_VERSION = "6.9.2"
     QT_ANDROID_PATH = "/opt/qt/${env.QT_VERSION}/android_arm64_v8a"
     QMAKE = "/opt/qt/${env.QT_VERSION}/android_arm64_v8a/bin/qmake"

ci/Jenkinsfile.ios

@@ -45,7 +45,7 @@ pipeline {
     GOTMPDIR = "${env.WORKSPACE_TMP}"
     PLATFORM = "ios/${getArch()}"
     /* Improve make performance */
-    MAKEFLAGS = "-j4 V=${params.VERBOSE}"
+    MAKEFLAGS = "-j${utils.getProcCount()} V=${params.VERBOSE}"
     QT_VERSION="6.9.2"
     QMAKE = "/Users/admin/${QT_VERSION}/ios/bin/qmake"
     QT_HOST_PATH = "/Users/admin/${QT_VERSION}/macos"

ci/Jenkinsfile.linux

@@ -76,7 +76,7 @@ pipeline {
   environment {
     PLATFORM = "linux/${getArch()}${(params.USE_NWAKU ?: false) ? '-nwaku' : ''}"
     /* Improve make performance */
-    MAKEFLAGS = "-j4 V=${params.VERBOSE}"
+    MAKEFLAGS = "-j${utils.getProcCount()} V=${params.VERBOSE}"
     /* Avoid weird bugs caused by stale cache. */
     QML_DISABLE_DISK_CACHE = "true"
     /* Set USE_NWAKU before VERSION since version.sh uses it */

ci/Jenkinsfile.linux-nix

@@ -59,7 +59,7 @@ pipeline {
   environment {
     PLATFORM = "linux-nix/${getArch()}"
     /* Improve make performance */
-    MAKEFLAGS = "-j4 V=${params.VERBOSE}"
+    MAKEFLAGS = "-j${utils.getProcCount()} V=${params.VERBOSE}"
     /* Avoid weird bugs caused by stale cache. */
     QML_DISABLE_DISK_CACHE = "true"
     /* Control output the filename */

ci/Jenkinsfile.macos

@@ -70,7 +70,7 @@ pipeline {
   environment {
     PLATFORM = "macos/${getArch()}${(params.USE_NWAKU ?: false) ? '-nwaku' : ''}"
     /* Improve make performance */
-    MAKEFLAGS = "-j4 V=${params.VERBOSE}"
+    MAKEFLAGS = "-j${utils.getProcCount()} V=${params.VERBOSE}"
     QT_VERSION="6.9.2"
     QMAKE = "/Users/admin/${QT_VERSION}/macos/bin/qmake"
     /* QMAKE = sh(script: "which qmake", returnStdout: true).trim() */

ci/Jenkinsfile.tests-ui

@@ -47,7 +47,7 @@ pipeline {
   environment {
     PLATFORM = 'tests/ui'
     /* Improve make performance */
-    MAKEFLAGS = "-j4 V=${params.VERBOSE}"
+    MAKEFLAGS = "-j${utils.getProcCount()} V=${params.VERBOSE}"
     /* Makefile assumes the compiler folder is included */
     QTDIR = "/opt/qt/6.9.2/gcc_64"
     PATH = "${env.QTDIR}/bin:${env.PATH}"
@@ -70,8 +70,10 @@ pipeline {
 
     stage('Check Translations') {
       steps {
-        script {
-          checkTranslations()
+        catchError(buildResult: 'SUCCESS', stageResult: 'FAILURE') {
+          script {
+            checkTranslations()
+          }
         }
       }
     }

mobile/android/qt6/AndroidManifest.xml

@@ -11,19 +11,21 @@
     <uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
     <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
     <uses-permission android:name="android.permission.VIBRATE" />
+    <uses-permission android:name="android.permission.USE_BIOMETRIC" />
+
+    <!-- features -->
+    <uses-feature android:name="android.hardware.camera" android:required="false" />
+    <uses-feature android:name="android.hardware.camera.autofocus" android:required="false" />
+    <uses-feature android:name="android.hardware.fingerprint" android:required="false" />
 
     <!-- dangerous permissions -->
     <uses-permission android:name="android.permission.CAMERA"/>
-    <uses-feature android:name="android.hardware.camera" />
-    <uses-feature android:name="android.hardware.camera.autofocus" />
-    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
     <uses-permission android:name="android.permission.READ_MEDIA_IMAGES"/>
-    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
+    <uses-permission android:name="android.permission.READ_MEDIA_AUDIO"/>
+    <uses-permission android:name="android.permission.READ_MEDIA_VIDEO"/>
     <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
-    <uses-permission android:name="android.permission.USE_FINGERPRINT" />
-    <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
-    <uses-permission android:name="android.permission.RECORD_AUDIO" />
-
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
+
     <supports-screens
         android:anyDensity="true"
         android:largeScreens="true"
@@ -36,7 +38,6 @@
         android:icon="@mipmap/ic_launcher"
         android:roundIcon="@mipmap/ic_launcher_round"
         android:theme="@style/Theme.AppSplash"
-        android:requestLegacyExternalStorage="true"
         android:allowBackup="true"
         android:hasFragileUserData="true"
         android:fullBackupOnly="false">

mobile/scripts/buildNimStatusClient.sh

@@ -58,6 +58,7 @@ env $FEATURE_FLAGS ./vendor/nimbus-build-system/scripts/env.sh nim c "${PLATFORM
     --cpu:"$CARCH" \
     --noMain:on \
     -d:release \
+    -d:production \
     --clang.exe="$CC" \
     --clang.linkerexe="$CC" \
     --dynlibOverrideAll \
@@ -67,4 +68,3 @@ env $FEATURE_FLAGS ./vendor/nimbus-build-system/scripts/env.sh nim c "${PLATFORM
 mkdir -p "$LIB_DIR"
 
 cp "$STATUS_DESKTOP/bin/libnim_status_client$LIB_EXT" "$LIB_DIR/libnim_status_client$LIB_EXT"
-

src/app/modules/main/profile_section/advanced/module.nim

@@ -63,7 +63,7 @@ method onFleetSet*(self: Module) =
   quit(QuitSuccess) # quits the app TODO: change this to logout instead when supported
 
 method getLogDir*(self: Module): string =
-  return url_fromLocalFile(constants.LOGDIR)
+  return constants.LOGDIR
 
 method getWakuV2LightClientEnabled*(self: Module): bool =
   return self.controller.getWakuV2LightClientEnabled()

src/app_service/service/chat/async_tasks.nim

@@ -105,7 +105,6 @@ type
   AsyncSendImagesTaskArg = ref object of QObjectTaskArg
     chatId: string
     imagePathsJson: string
-    tempDir: string
     msg: string
     replyTo: string
     preferredUsername: string
@@ -118,14 +117,12 @@ const asyncSendImagesTask: Task = proc(argEncoded: string) {.gcsafe, nimcall.} =
   try:
     var images = Json.decode(arg.imagePathsJson, seq[string])
     var imagePaths: seq[string] = @[]
-    var tempPaths: seq[string] = @[]
 
     for imagePathOrSource in images.mitems:
       if utils.isBase64DataUrl(imagePathOrSource):
-        let imagePath = save_byte_image_to_file(imagePathOrSource, arg.tempDir)
+        let imagePath = save_byte_image_to_file(imagePathOrSource)
         if imagePath != "":
           imagePaths.add(imagePath)
-          tempPaths.add(imagePath)
       else:
         imagePaths.add(imagePathOrSource)
 
@@ -140,9 +137,6 @@ const asyncSendImagesTask: Task = proc(argEncoded: string) {.gcsafe, nimcall.} =
       arg.paymentRequests
     )
 
-    for imagePath in tempPaths:
-      removeFile(imagePath)
-
     arg.finish(%* {
       "response": response,
       "chatId": arg.chatId,

src/app_service/service/chat/service.nim

@@ -15,7 +15,6 @@ import backend/group_chat as status_group_chat
 import app/global/[global_singleton, utils]
 import app/core/eventemitter
 import app/core/signals/types
-import constants
 
 import ../../common/message as message_common
 
@@ -428,7 +427,6 @@ QtObject:
         slot: "onAsyncSendImagesDone",
         chatId: chatId,
         imagePathsJson: imagePathsJson,
-        tempDir: TMPDIR.replace("\\", "\\\\"), # Escape backslashes so that the JSON sent is valid (Windows issue)
         msg: msg,
         replyTo: replyTo,
         preferredUsername: preferredUsername,

storybook/CMakeLists.txt

@@ -29,7 +29,7 @@ if(MSVC)
 endif()
 
 if (APPLE)
-    set(MACOS_VERSION_MIN_FLAGS -mmacosx-version-min=11.0)
+    set(MACOS_VERSION_MIN_FLAGS -mmacosx-version-min=14.0)
 endif()
 
 find_package(QT NAMES Qt5 Qt6 REQUIRED COMPONENTS Core)

storybook/pages/StatusNavBarTabButtonPage.qml

@@ -4,6 +4,9 @@ import QtQuick.Controls
 import StatusQ.Controls
 import StatusQ.Components.private
 import StatusQ.Core.Theme
+import StatusQ.Popups
+
+import shared.controls.chat.menuItems
 
 import Models
 import Storybook
@@ -13,6 +16,7 @@ SplitView {
 
     ButtonGroup {
         buttons: column.children
+        onClicked: button => console.info("Clicked button:", button.tooltip.text)
     }
 
     Rectangle {
@@ -82,6 +86,38 @@ SplitView {
                 //     when: ctrlNewBadgeGradient.checked
                 // }
             }
+            StatusNavBarTabButton {
+                icon.name: "info"
+                tooltip.text: "With context menu"
+                thirdpartyServicesEnabled: thirdpartyServicesCtrl.checked
+                popupMenu: popupMenuComp
+            }
+        }
+    }
+
+    Component {
+        id: popupMenuComp
+        StatusMenu {
+            StatusAction {
+                text: qsTr("Invite People")
+                icon.name: "share-ios"
+            }
+
+            StatusAction {
+                text: qsTr("Community Info")
+                icon.name: "info"
+            }
+
+            StatusAction {
+                text: qsTr("Community Rules")
+                icon.name: "text"
+            }
+
+            StatusMenuSeparator {}
+
+            MuteChatMenuItem {
+                title: qsTr("Mute Community")
+            }
         }
     }
 

storybook/pages/SupportedTokenListsPanelPage.qml

@@ -6,7 +6,6 @@ import Storybook
 import Models
 
 import AppLayouts.Profile.panels
-import AppLayouts.Profile.stores
 
 import StatusQ
 
@@ -39,7 +38,6 @@ SplitView {
 
     Logs { id: logs }
 
-
     Pane {
         SplitView.fillWidth: true
         SplitView.fillHeight: true
@@ -48,8 +46,6 @@ SplitView {
             anchors.fill: parent
             sourcesOfTokensModel: root.sourcesOfTokensModel
             tokensListModel: root.tokensProxyModel
-
-            onItemClicked: logs.logEvent("SupportedTokenListsPanel::onItemClicked --> Key --> " + key)
         }
     }
 

ui/StatusQ/include/StatusQ/urlutils.h

@@ -40,4 +40,8 @@ class UrlUtils : public QObject
     // ["jpg", "jpe", "jp", "jpeg", "png", "webp", "gif", "svg"]
     QStringList m_allImgExtensions;
     QStringList allValidImageExtensions() const { return m_allImgExtensions; }
+
+#ifdef Q_OS_ANDROID
+    QString resolveAndroidContentUrl(const QString& urlPath) const;
+#endif
 };

ui/StatusQ/src/StatusQ/Components/StatusMessage.qml

@@ -334,7 +334,7 @@ Control {
                                     albumCount: root.messageDetails.albumCount > 0 ? root.messageDetails.albumCount : 1
                                     imageWidth: Math.min(messageLayout.width / root.messageDetails.albumCount - 9 * (root.messageDetails.albumCount - 1), 144)
                                     shapeType: StatusImageMessage.ShapeType.LEFT_ROUNDED
-                                    onImageClicked: root.imageClicked(image, mouse, imageSource)
+                                    onImageClicked: (image, mouse, imageSource) => root.imageClicked(image, mouse, imageSource)
                                 }
                             }
                         }

ui/StatusQ/src/StatusQ/Controls/StatusNavBarTabButton.qml

@@ -1,9 +1,9 @@
 import QtQuick
+import QtQuick.Controls
 
 import StatusQ.Core
 import StatusQ.Components
 import StatusQ.Controls
-import StatusQ.Popups
 import StatusQ.Core.Theme
 
 StatusIconTabButton {
@@ -28,7 +28,7 @@ StatusIconTabButton {
         visible: statusNavBarTabButton.hovered && !!statusTooltip.text
         delay: 50
         orientation: StatusToolTip.Orientation.Right
-        x: statusNavBarTabButton.width + 16
+        x: statusNavBarTabButton.width + Theme.padding
         y: statusNavBarTabButton.height / 2 - height / 2 + 4
     }
 
@@ -62,36 +62,14 @@ StatusIconTabButton {
         border.width: 2
     }
 
-    StatusMouseArea {
-        anchors.fill: parent
-        cursorShape: Qt.PointingHandCursor
-        acceptedButtons: Qt.LeftButton | Qt.RightButton
-        onClicked: function(mouse) {
-            if (mouse.button === Qt.RightButton) {
-                if (!!popupMenuSlot.sourceComponent && !popupMenuSlot.active)
-                    popupMenuSlot.active = true
-                if (popupMenuSlot.active) {
-                    statusNavBarTabButton.highlighted = true
-                    let btnWidth = statusNavBarTabButton.width
-                    popupMenuSlot.item.popup(parent.x + btnWidth + 4, -2)
-                }
-            } else if (mouse.button === Qt.LeftButton) {
-                statusNavBarTabButton.toggle()
-                statusNavBarTabButton.clicked()
-            }
-        }
+    function openContextMenu(pos) {
+        if (!popupMenu)
+            return
+        const menu = popupMenu.createObject(statusNavBarTabButton)
+        statusTooltip.hide()
+        menu.popup(pos)
     }
 
-    Loader {
-        id: popupMenuSlot
-        sourceComponent: statusNavBarTabButton.popupMenu
-        active: false
-        onLoaded: {
-            popupMenuSlot.item.closeHandler = function () {
-                statusNavBarTabButton.highlighted = false
-                popupMenuSlot.active = false
-            }
-        }
-    }
+    ContextMenu.onRequested: pos => openContextMenu(pos)
+    onPressAndHold: openContextMenu(Qt.point(statusNavBarTabButton.pressX, statusNavBarTabButton.pressY))
 }
-