-
Notifications
You must be signed in to change notification settings - Fork 1k
Quo component: Market token list item #22428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jenkins BuildsClick to see older builds (24)
|
| :on-long-press on-long-press | ||
| :accessibility-label :market-token-container} | ||
| [rn/view | ||
| {:style {:flex-direction :row |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥, Saw some inline styles, maybe worth popping them into the style file.
shivekkhurana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except from inline styles, everything else looks good.
|
Thanks, fixed the styles |
|
Hi @vkjr ! Thanks for your PR. |
0cdc63c to
b24d28d
Compare
|
@mariia-skrypnyk, hey! |
b24d28d to
ab45648
Compare
61% of end-end tests have passedFailed tests (8)Click to expandClass TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestProfileMultipleDevices:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (14)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestWalletOneDeviceTwo:
Class TestWalletCollectibles:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
62% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (5)Click to expandClass TestProfileMultipleDevices:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
|
|
Thanks @vkjr ! Checked @Francesca-G can you please look from your side? |
|
@Francesca-G, thank you! |
01964a8 to
c38b01b
Compare
|
@Francesca-G, I've fixed the horizontal padding of the counter but can't ideally center it programmatically within the border. I believe this is a common issue. |
Counter looks good 👍
|
|
@Francesca-G this is closest what I could achieve :) This is the issue on coding side of things: So here I lined up two texts by baseline but distance between them is now "1 whitespace", not precise value in pixels. |
this looks good, thank you 🙏 nice job! |
|
@Francesca-G, thank you! |
ec8c338 to
80a6f5d
Compare




fixes #22376
Summary
Implementation of quo component - list item for Market tab.
CleanShot.2025-04-02.at.16.19.09.mp4
Figma link
Review notes
Platforms
Areas that may be impacted
Shouldn't affect anything except components
Steps to test
market-tokenunderlist-itemsectionstatus: ready