[Fixes: #12061] Add unread mentions count#12152
Merged
Conversation
flexsurfer
approved these changes
May 26, 2021
Member
Jenkins BuildsClick to see older builds (12)
|
cammellos
force-pushed
the
feature/#12061-show-mentions-count
branch
from
c5ed937 to
5ab42ab
Compare
Member
79% of end-end tests have passedFailed tests (15)Click to expand
Passed tests (55)Click to expand |
cammellos
force-pushed
the
feature/#12061-show-mentions-count
branch
from
5ab42ab to
51c6c32
Compare
Member
60% of end-end tests have passedFailed tests (6)Click to expand
Passed tests (9)Click to expand
|
Contributor
|
@cammellos caught by e2e and can be reproduced manually: ISSUE 1: when chat appears in activity centre with command message, it is shown as group chatSteps:
Expected result: OS: IOS, Android Also can you please rebase PR to recent develop, as several e2e are fixed there? |
cammellos
force-pushed
the
feature/#12061-show-mentions-count
branch
from
51c6c32 to
8c8e977
Compare
Contributor
ISSUE 2: unread messages counter is reset after reloginSteps:
Expected result: |
cammellos
force-pushed
the
feature/#12061-show-mentions-count
branch
from
8c8e977 to
5dbc922
Compare
Member
99% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (69)Click to expand |
Contributor
Author
|
@churik is that related or separate? |
Contributor
|
e2e failures are not related to PR, looking into this separately |
Contributor
|
Tested basic flows, mentioned in description + communities + PNs. Devices:
|
cammellos
force-pushed
the
feature/#12061-show-mentions-count
branch
2 times, most recently
from
439e762 to
ef13b4d
Compare
Fixes: #2061 This commit adds an unread mentions count in 3 places: 1) Public chats 2) Communities in home 3) Communities chats The logic is that if you have unread mentions, it will show you the count of messages with unread mentions, while if you have only unread messages, you will see a blue dot. Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12061
This commit adds an unread mentions count in 3 places:
The logic is that if you have unread mentions, it will show you the
count of messages with unread mentions, while if you have only unread
messages, you will see a blue dot.
cc @errorists