[Fixes: #12140] Don't show gap after 30 days and allow user to set ms#12166
Merged
[Fixes: #12140] Don't show gap after 30 days and allow user to set ms#12166
Conversation
Member
Jenkins BuildsClick to see older builds (8)
|
cammellos
force-pushed
the
bug/#12140-dont-show-gap-after-30-days
branch
from
e5d7cb9 to
9aa3149
Compare
flexsurfer
approved these changes
May 28, 2021
Contributor
flexsurfer
left a comment
flexsurfer
left a comment
There was a problem hiding this comment.
did you write py test ? :)
| (views/defview default-sync-period-settings [] | ||
| (views/letsubs [{:keys [default-sync-period]} [:multiaccount]] | ||
| [react/view {:flex 1} | ||
| [topbar/topbar {:title (i18n/label :t/show-profile-pictures)}] |
Contributor
There was a problem hiding this comment.
show-profile-pictures ?
Member
86% of end-end tests have passedFailed tests (10)Click to expand
Passed tests (60)Click to expand
|
cammellos
force-pushed
the
bug/#12140-dont-show-gap-after-30-days
branch
2 times, most recently
from
587123f to
d4e1020
Compare
Member
90% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (9)Click to expand
|
cammellos
force-pushed
the
bug/#12140-dont-show-gap-after-30-days
branch
from
d4e1020 to
54fac0f
Compare
cammellos
force-pushed
the
bug/#12140-dont-show-gap-after-30-days
branch
from
54fac0f to
505b290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a setting in sync section so that user can select the
amount of days the can sync.