Add mention notifications to activity center & empty state#12227
Merged
briansztamfater merged 1 commit intodevelopfrom Jul 2, 2021
Merged
Add mention notifications to activity center & empty state#12227briansztamfater merged 1 commit intodevelopfrom
briansztamfater merged 1 commit intodevelopfrom
Conversation
Member
Jenkins BuildsClick to see older builds (64)
|
briansztamfater
force-pushed
the
feature/mention-activity-center
branch
from
72b1081 to
a738eb6
Compare
briansztamfater
changed the title
briansztamfater
force-pushed
the
feature/mention-activity-center
branch
3 times, most recently
from
28995db to
5361399
Compare
briansztamfater
force-pushed
the
feature/mention-activity-center
branch
from
5361399 to
98d2d11
Compare
Member
87% of end-end tests have passedFailed tests (9)Click to expand
Passed tests (61)Click to expand |
Contributor
|
@briansztamfater could you rebase against latest develop please? |
briansztamfater
force-pushed
the
feature/mention-activity-center
branch
from
98d2d11 to
694df53
Compare
Member
100% of end-end tests have passedPassed tests (70)Click to expand |
Contributor
|
@briansztamfater thanks for PR! ISSUE 1: Unread indicator for new mentions on the Activity center bell doesn't disappear if open chat with received mention from the Home screenSteps:
UserB:
UserA:
UserB:
Expected result: the new mention indicator disappears after opening a chat containing it, no matter what screen it was opened from IMG_0735.mp4ISSUE 2: Notifications for mentions in the activity center are duplicated if they are received from different chats (it can be group and community, or two communities) while the User is in the activity center screen, and if the activity center already contains at least two notifications from one type of chatSteps: UserA:
UserB: UserA: UserB: OS: iOS, Android On the video below only one mention in the community was received. The two top notifications from the group chat are duplicates. IMG_0733.mp4While attempting to open duplicated notification get error It seems like an edge case. ISSUE 3: Double
|
Contributor
Author
|
@qoqobolo Thanks for pointing out these issues, all of them make sense to fix and working on them right now. |
briansztamfater
force-pushed
the
feature/mention-activity-center
branch
2 times, most recently
from
d911f06 to
0ddb7de
Compare
Contributor
Author
|
@qoqobolo issues should be fixed. Let me know how it goes :) |
Contributor
|
@briansztamfater thank you! Unfortunately, issue 1 and issue 3 are still reproducible :( Issue 1 is fixed only for group chats. Also, this issue is relevant for cases when a user receives a mention while in the chat view (both group chat and community). Issue 3 |
Contributor
Author
|
@qoqobolo you are right, made new changes and hopefully they should be fixed now |
briansztamfater
force-pushed
the
feature/mention-activity-center
branch
from
eabb550 to
6e5cea2
Compare
Contributor
|
@briansztamfater thanks, looks great now! Could you add accessibility-ids for these elements, please?
After that, PR will be ready to merge. Tested:
|
briansztamfater
force-pushed
the
feature/mention-activity-center
branch
from
0420379 to
4fd6f0b
Compare
Contributor
Author
|
@qoqobolo Thanks, added accessibility ids and rebased, let me know if you need anything else :) I need a code review approve in order to merge so maybe I'll request a quick re-test in case we need to change anything. |
flexsurfer
reviewed
Jun 30, 2021
| parsed-text)] | ||
| (:components result)))) | ||
|
|
||
| (defn message-content-text [{:keys [content content-type community-id]}] |
Contributor
There was a problem hiding this comment.
just wondering if this duplicated from home screen? could we reuse functions from home ?
Contributor
Author
There was a problem hiding this comment.
The styles and some minor logic is different, i.e. mention-element that always show an @, and if there's no message on the notification we show the text in gray
briansztamfater
force-pushed
the
feature/mention-activity-center
branch
from
4fd6f0b to
234d744
Compare
Signed-off-by: Brian Sztamfater <brian@status.im>
briansztamfater
force-pushed
the
feature/mention-activity-center
branch
from
234d744 to
af9461d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12064
fixes #12237
fixes #12238
fixes #12250
Summary
This PR adds mention notification to activity center. Based on designs, there are a couple of things that needs to be refactored to fully comply with the whole activity center feature expected UI/UX, and will be handled on a series of different PRs. Some things that still need to be worked are:
However, I took advantage and added a bit more to the scope for the sake of UI consistency:
Screenshots
Testing notes
Platforms
Functional
Steps to test
status: ready