allow migration to Keycard keeping the db#12306
Merged
Conversation
Member
Jenkins BuildsClick to see older builds (25)
|
bitgamma
changed the title
flexsurfer
reviewed
Jul 16, 2021
| [quo/button {:type :secondary | ||
| :on-press #(re-frame/dispatch [::multiaccounts.key-storage/skip-password-pressed])} | ||
| (i18n/label :t/skip)]]] | ||
| [react/view {:height 1 :background-color colors/gray-lighter}] |
Contributor
There was a problem hiding this comment.
is this quo/separator ?
flexsurfer
approved these changes
Jul 16, 2021
Member
87% of end-end tests have passedFailed tests (9)Click to expand
Passed tests (62)Click to expand |
Member
89% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (8)Click to expand
|
Member
Author
|
failed test is because the reset database checkbox is not checked anymore automatically when migrating (by default, we want to keep the db). |
Contributor
|
@bitgamma thank you! Works great. ISSUE 1: account restored from seed phrase (or private key) remains after moving to keycard storageCurrently, if you create multiaccount with keycard, there is no option to add account in wallet using seed phrase or private key.
Expected result: OS: IOS, Android ISSUE 2: 'Lock app with fingerprint (Face ID)' remains enabled after moving to keycard storageIMO better to reset it and ask user to enable it again, as currently it crashes app on IOS and not working until app reopening (religion) on Android Steps:
Expected result:
|
Member
Author
|
@churik thanks for catching this! should be fixed now. Seed and private keys subaccounts are removed, while watch and derived paths are kept. |
Contributor
|
@bitgamma previous issues are fixed, thank you! ISSUE 3: "back up seed phrase" is shown if migrate restored multiaccount to keycardSteps:
Expected result: Actual result: OS: IOS, Android |
Member
Author
|
@churik fixed now, thanks! |
Contributor
|
All fixed.
|
Signed-off-by: Michele Balistreri <michele@bitgamma.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11777.
Fixes #11659.