Add Jenkins parameterized build config file#2564
Conversation
Jenkinsfile.parameters
Outdated
|
|
||
| stage('Slack Notification') { | ||
| def c = (testPassed ? 'good' : 'warning' ) | ||
| slackSend color: c, message: 'Branch: ' + BRANCH_NAME + |
There was a problem hiding this comment.
Should probably print repo
|
Moved to 'ready for testing', possibly prematurely for two reasons:
Regardless it'd be good to get a review on this, pinging 9-dev-xp swarm for thoughts. See comments for known downsides #2511 (comment) - if you have solutions shoot. I know it can be shell-fued but didn't have time to make it robust enough, hence this simplistic approach. |
|
@rasom what parameters do we toggle for the production release and with what values? It would be great if we can just build the release candidates on our own using the params in Jenkins. So, if some of the "production" parameters is missing, please tell which one. And of course which values to use :) |
|
@annadanchenko https://github.com/status-im/status-react/blob/develop/.env.prod Additionally some certificate stuff, but we can defo do RC this way :) |
|
Before merge: probably fix this #2553 (review) |
|
@oskarth i also added repo name to slack messages in jenkins configurations, it makes a bit simpler to distinguish parametrized builds from these which are built form branches, like slackSend color: 'good', message: REPO + ":" + BRANCH_NAME + ' build started. ' + env.BUILD_URLand slackSend color: c, message: 'Branch: ' + REPO + ":" + BRANCH_NAME + |
Jenkinsfile.parameters
Outdated
| sh 'echo "**********************************************************************"' | ||
|
|
||
| sh 'lein deps && npm install && ./re-natal deps' | ||
| sh 'sed -i "" "s/301000/1201000/g" node_modules/react-native/packager/src/JSTransformer/index.js' |
There was a problem hiding this comment.
I think we should remove this line now, also once react-native will be updated this won't work anymore as the packager is now a separate project
There was a problem hiding this comment.
@yenda Can you raise an issue and we test/do this in a separate PR and for all Jenkinsfiles? This is not in scope of this PR IMO (and also need to update it in Jenkins).
There was a problem hiding this comment.
let's just try it on jenkins first
There was a problem hiding this comment.
It was already commented out in jenkins until @oskarth updated it with that script
|
Thanks @rasom, I'll look at this file in Jenkins and put it in this file, then merge. Soonish. |
|
FYI, added this to live version (with same default values as env.jenkins): Also uncommented back |
|
@oskarth No, it was update-react-native build only that was failing and it is not related to this. Now it will fail because of the sed |
73a308b to
575ca52
Compare
575ca52 to
8fb2c13
Compare
Addresses #2511
reviewers: sanity check (actual code is in Jenkins anyway)
testers: feedback on what you want to toggle, and test parameterized build
status: ready