-
Notifications
You must be signed in to change notification settings - Fork 1k
Add ethereum/log events [#6601] #6852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Checklist
|
|
@jeluard I ended up supporting topics definition like that: every topic can be:
putting all together, it is possible to use the new event as follows: some considerations:
|
|
@tbenr Wow very nice work!
That would be really cool! Any chance you have some small extension that would demo it's usage? |
|
@jeluard thanks!
I was actually a very basic\non-sense extension to test it. Let me try to clean it up.
👍 |
|
@tbenr When you are done, you might be interested with those issues too : :) |
|
@jeluard sure:) already applied for the ENS integration.
I have to check what's happening (if you have any hint...) |
|
@tbenr Doesn't ring a bell right now. I don't see how it could be related to your PR. Maybe the extension you are using? |
|
could be... in the weekend i'll figure out and make the final PR. @jeluard btw the extension is: https://status-im.github.io/pluto/try.html?hash=QmPmydboqsmkuRg5DZZUEM7p4n5XNXtRgwwQc7tTa75fT4 |
cb09646 to
023bd05
Compare
|
@jeluard a dummy extension containing some usage examples is here: https://status-im.github.io/pluto/try.html?hash=QmfAWruXYfDzZVD59qWNL8DAxqsmpaFrsDeyd2gxJuuDRt
|
|
Fantastic job @tbenr ! Can I just ask you to remove the |
|
Oh also please rename |
023bd05 to
8cceeeb
Compare
|
@jeluard thanks! last commit includes:
this is the updated sample extension: https://status-im.github.io/pluto/try.html?hash=Qmb7opEFGGTrjo6mt5DxjfZUJFLKEDFsTVsfb7LyTv7sxp
|
|
@tbenr Awesome thanks! |
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
8cceeeb to
2d5c4e3
Compare
|
Hey @tbenr please will you update your Eth address in Gitcoin so that I can pay out this bounty? Currently it will not let me do so. |
|
@andytudhope it was already in my account, in any case I updated it. |
fixes #6601