Skip to content

[#7671] remove ability to change values while signing transaction #7827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2019
Merged

[#7671] remove ability to change values while signing transaction #7827

merged 1 commit into from
Apr 24, 2019

Conversation

trowacat
Copy link
Contributor

@trowacat trowacat commented Mar 25, 2019 •
edited by 0xc1c4da
Loading

Disabled the input fields while the enter password window is open when signing a transaction

fixes #7671

Summary:

Had the ability to change values while signing a transaction which was error prone, this disables ability to change values while siging

status: ready

@ghost
Copy link

ghost commented Mar 25, 2019 •
edited by mandrigin
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Mar 25, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (27)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 01dccaf #1 2019-03-25 20:45:28 ~42 sec linux 📄 log
✔️ 01dccaf #1 2019-03-25 21:00:45 ~15 min macos 📦 dmg
✔️ 01dccaf #1 2019-03-25 21:02:10 ~17 min ios 📦 ipa
✔️ 01dccaf #1 2019-03-25 21:12:03 ~27 min android 📦 apk
✔️ 01dccaf #1 2019-03-25 21:12:20 ~27 min android-e2e 📦 apk
❌ 6750f13 #3 2019-03-30 12:41:40 ~30 sec android-e2e 📄 log
❌ 6750f13 #3 2019-03-30 12:41:41 ~29 sec android 📄 log
❌ 6750f13 #3 2019-03-30 12:41:42 ~27 sec ios 📄 log
❌ 6750f13 #3 2019-03-30 12:41:51 ~33 sec macos 📄 log
❌ 6750f13 #3 2019-03-30 12:41:52 ~36 sec linux 📄 log
❌ 6750f13 #3 2019-03-30 12:41:54 ~33 sec windows 📄 log
✔️ 17f150d #4 2019-03-30 13:19:59 ~16 min ios 📦 ipa
✔️ 17f150d #4 2019-03-30 13:20:52 ~16 min macos 📦 dmg
✔️ 17f150d #4 2019-03-30 13:23:47 ~19 min android-e2e 📦 apk
✔️ 17f150d #4 2019-03-30 13:23:48 ~19 min android 📦 apk
✔️ e04aabb #6 2019-03-30 13:42:27 ~16 min macos 📦 dmg
✔️ e04aabb #6 2019-03-30 13:42:31 ~16 min ios 📦 ipa
✔️ e04aabb #6 2019-03-30 13:44:18 ~18 min android 📦 apk
✔️ e04aabb #6 2019-03-30 13:44:27 ~18 min android-e2e 📦 apk
✔️ e04aabb #6 2019-03-30 13:46:52 ~21 min windows 📦 exe
✔️ e04aabb #6 2019-03-30 13:47:30 ~21 min linux 📦 App
❌ e04aabb #7 2019-04-16 07:09:46 ~32 sec null 📄 log
❌ e04aabb #7 2019-04-16 07:11:47 ~2 min null-e2e 📄 log
❌ e04aabb #7 2019-04-16 07:11:47 ~3 min null 📄 log
❌ e04aabb #7 2019-04-16 07:19:31 ~9 min null 📄 log
✔️ e04aabb #7 2019-04-16 07:22:47 ~13 min null 📦 dmg
✔️ e04aabb #7 2019-04-16 07:30:43 ~21 min null 📦 App
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f0aadea #9 2019-04-20 14:25:16 ~12 min macos 📦 dmg
✔️ f0aadea #9 2019-04-20 14:26:17 ~13 min linux 📦 App
✔️ f0aadea #9 2019-04-20 14:31:11 ~18 min windows 📦 exe
✔️ f0aadea #9 2019-04-20 14:35:26 ~22 min ios 📦 ipa
✔️ f0aadea #9 2019-04-20 14:36:08 ~23 min android 📦 apk
✔️ f0aadea #10 2019-04-22 11:11:54 ~22 min android-e2e 📦 apk
✔️ 170c842 #11 2019-04-23 21:51:13 ~12 min macos 📦 dmg
✔️ 170c842 #11 2019-04-23 21:52:22 ~14 min linux 📦 App
✔️ 170c842 #11 2019-04-23 21:56:05 ~17 min windows 📦 exe
✔️ 170c842 #11 2019-04-23 22:03:36 ~25 min ios 📦 ipa
✔️ 170c842 #11 2019-04-23 22:03:42 ~25 min android 📦 apk
✔️ 170c842 #13 2019-04-24 06:46:47 ~20 min android-e2e 📦 apk

@trowacat trowacat force-pushed the issue7671 branch 2 times, most recently from b70794a to e04aabb Compare March 30, 2019 13:25
@asemiankevich asemiankevich self-assigned this Apr 15, 2019
@statustestbot
Copy link

94% of end-end tests have passed

Total executed tests: 47
Failed tests: 3
Passed tests: 44

Failed tests (3)

Click to expand
1. test_public_chat_messaging

Device 1: Tap on ProfileButton
Device 1: Wait for ShareMyProfileButton

Device 1: 'DefaultUserNameText' is not found on the screen

Device sessions

2. test_send_message_in_group_chat

Device 2: Tap on CrossIcon
Device 2: Wait for ShareMyProfileButton

Device 2: 'DefaultUserNameText' is not found on the screen

Device sessions

3. test_offline_status

Device 1: Looking for an element by text: 'Network & Internet'
Device 1: Looking for an element by xpath: '//*[@resource-id="android:id/switch_widget"]'

An unknown server-side error occurred while processing the command. Original error: Cannot start the 'im.status.ethereum.pr' application. Visit https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/android/activity-startup.md for tr

Device sessions

Passed tests (44)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_request_and_receive_tokens_in_1_1_chat
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_password_in_logcat_sign_in
Device sessions

7. test_text_message_1_1_chat
Device sessions

8. test_add_to_contacts
Device sessions

9. test_sign_typed_message (TestRail link is not found)
Device sessions

10. test_unread_messages_counter_1_1_chat
Device sessions

11. test_logcat_send_transaction_from_daap
Device sessions

12. test_logcat_send_transaction_from_wallet
Device sessions

13. test_send_token_with_7_decimals
Device sessions

14. test_modify_transaction_fee_values
Device sessions

15. test_send_eth_from_wallet_to_address
Device sessions

16. test_manage_assets
Device sessions

17. test_logcat_send_transaction_in_1_1_chat
Device sessions

18. test_request_and_receive_eth_in_1_1_chat
Device sessions

19. test_swipe_to_delete_public_chat
Device sessions

20. test_send_emoji
Device sessions

21. test_search_chat_on_home
Device sessions

22. test_logcat_recovering_account
Device sessions

23. test_messaging_in_different_networks
Device sessions

24. test_send_tokens_in_1_1_chat
Device sessions

25. test_network_mismatch_for_send_request_commands
Device sessions

26. test_logcat_sign_message_from_daap
Device sessions

27. test_swipe_to_delete_1_1_chat
Device sessions

28. test_switch_users_and_add_new_account
Device sessions

29. test_send_stt_from_wallet
Device sessions

30. test_send_eth_in_1_1_chat
Device sessions

31. test_login_with_new_account
Device sessions

32. test_send_eth_from_wallet_to_contact
Device sessions

33. test_add_contact_from_public_chat
Device sessions

34. test_send_two_transactions_one_after_another_in_dapp
Device sessions

35. test_password_in_logcat_creating_account
Device sessions

36. test_backup_recovery_phrase
Device sessions

37. test_open_google_com_via_open_dapp
Device sessions

38. test_unread_messages_counter_public_chat
Device sessions

39. test_sign_message_from_daap
Device sessions

40. test_user_can_remove_profile_picture
Device sessions

41. test_share_contact_code_and_wallet_address
Device sessions

42. test_request_eth_in_wallet
Device sessions

43. test_refresh_button_browsing_app_webview
Device sessions

44. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@statustestbot
Copy link

0% of end-end tests have passed

Total executed tests: 3
Failed tests: 3
Passed tests: 0

Failed tests (3)

Click to expand
1. test_public_chat_messaging

Device 1: Tap on ProfileButton
Device 1: Wait for ShareMyProfileButton

Device 1: 'DefaultUserNameText' is not found on the screen

Device sessions

2. test_send_message_in_group_chat

Device 2: Tap on CrossIcon
Device 2: Wait for ShareMyProfileButton

Device 2: 'DefaultUserNameText' is not found on the screen

Device sessions

3. test_offline_status

Device 1: Looking for an element by text: 'Network & Internet'
Device 1: Looking for an element by xpath: '//*[@resource-id="android:id/switch_widget"]'

An unknown server-side error occurred while processing the command. Original error: Cannot start the 'im.status.ethereum.pr' application. Visit https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/android/activity-startup.md for tr

Device sessions

@asemiankevich
Copy link
Contributor

@trowacat would you mind to rebase please? thanks!

@trowacat trowacat force-pushed the issue7671 branch 2 times, most recently from f8b3901 to f0aadea Compare April 20, 2019 14:12
@oskarth
Copy link
Contributor

oskarth commented Apr 22, 2019

@asemiankevich Is it ready to be tested again?

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 47
Failed tests: 0
Passed tests: 47

Passed tests (47)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_request_and_receive_tokens_in_1_1_chat
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_public_chat_messaging
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_text_message_1_1_chat
Device sessions

9. test_add_to_contacts
Device sessions

10. test_sign_typed_message (TestRail link is not found)
Device sessions

11. test_unread_messages_counter_1_1_chat
Device sessions

12. test_logcat_send_transaction_from_daap
Device sessions

13. test_send_message_in_group_chat
Device sessions

14. test_logcat_send_transaction_from_wallet
Device sessions

15. test_send_token_with_7_decimals
Device sessions

16. test_modify_transaction_fee_values
Device sessions

17. test_send_eth_from_wallet_to_address
Device sessions

18. test_manage_assets
Device sessions

19. test_logcat_send_transaction_in_1_1_chat
Device sessions

20. test_request_and_receive_eth_in_1_1_chat
Device sessions

21. test_swipe_to_delete_public_chat
Device sessions

22. test_send_emoji
Device sessions

23. test_search_chat_on_home
Device sessions

24. test_logcat_recovering_account
Device sessions

25. test_messaging_in_different_networks
Device sessions

26. test_send_tokens_in_1_1_chat
Device sessions

27. test_network_mismatch_for_send_request_commands
Device sessions

28. test_logcat_sign_message_from_daap
Device sessions

29. test_swipe_to_delete_1_1_chat
Device sessions

30. test_switch_users_and_add_new_account
Device sessions

31. test_send_stt_from_wallet
Device sessions

32. test_send_eth_in_1_1_chat
Device sessions

33. test_login_with_new_account
Device sessions

34. test_send_eth_from_wallet_to_contact
Device sessions

35. test_add_contact_from_public_chat
Device sessions

36. test_send_two_transactions_one_after_another_in_dapp
Device sessions

37. test_password_in_logcat_creating_account
Device sessions

38. test_backup_recovery_phrase
Device sessions

39. test_offline_status
Device sessions

40. test_open_google_com_via_open_dapp
Device sessions

41. test_unread_messages_counter_public_chat
Device sessions

42. test_sign_message_from_daap
Device sessions

43. test_user_can_remove_profile_picture
Device sessions

44. test_share_contact_code_and_wallet_address
Device sessions

45. test_request_eth_in_wallet
Device sessions

46. test_refresh_button_browsing_app_webview
Device sessions

47. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@asemiankevich asemiankevich requested a review from dmitryn April 22, 2019 12:43
@asemiankevich
Copy link
Contributor

@oskarth just tested it - looks good to me from feature perspective , however i am confused of 391 file changed by this PR, is it expected? @mandrigin @pombeirp
@dmitryn maybe you could take a look?

@rasom
Copy link
Contributor

rasom commented Apr 22, 2019

@asemiankevich no it is not expected, this change should be properly rebased before merging

@asemiankevich
Copy link
Contributor

@trowacat Brandon , seems you need to rebase again , please take a look

@trowacat trowacat force-pushed the issue7671 branch 2 times, most recently from ab19e96 to 170c842 Compare April 23, 2019 21:38
@trowacat
Copy link
Contributor Author

@asemiankevich yes sorry, I'm not sure what happened. FIxed. Thanks.

@asemiankevich
Copy link
Contributor

looks good, thanks

@trowacat @flexsurfer
remove ability to change values while signing transaction
7017736 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit 7017736 into status-im:develop Apr 24, 2019
@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitryn dmitryn Awaiting requested review from dmitryn

2 more reviewers

@pedropombeiro pedropombeiro pedropombeiro approved these changes

@mandrigin mandrigin mandrigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tested - OK

Projects

No open projects
Legacy QA Automation Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can try to sign transaction with empty amount "Nulll is not an object (evaluating ''e.replace") if change amount or asset

9 participants

@trowacat @status-im-auto @statustestbot @asemiankevich @oskarth @rasom @pedropombeiro @mandrigin @flexsurfer