Bug 1824112 - switch to addLoginAsync r=credential-management-reviewers,sgalich,sync-reviewers,markh

Differential Revision: https://phabricator.services.mozilla.com/D175666

Author: jo

services/fxaccounts/FxAccountsStorage.sys.mjs

@@ -562,7 +562,7 @@ LoginManagerStorage.prototype = {
       if (existingLogins.length) {
         Services.logins.modifyLogin(existingLogins[0], login);
       } else {
-        Services.logins.addLogin(login);
+        await Services.logins.addLoginAsync(login);
       }
       log.trace("finished write of user data to the login manager");
     } catch (ex) {

services/sync/modules/engines/passwords.sys.mjs

@@ -346,7 +346,7 @@ PasswordStore.prototype = {
         "formSubmitURL: " +
         JSON.stringify(login.formActionOrigin)
     );
-    Services.logins.addLogin(login);
+    await Services.logins.addLoginAsync(login);
   },
 
   async remove(record) {

services/sync/tps/extensions/tps/resource/modules/passwords.sys.mjs

@@ -99,6 +99,7 @@ Password.prototype = {
       this.props.usernameField,
       this.props.passwordField
     );
+    // TODO: use `addLoginAsync` instead, see https://bugzilla.mozilla.org/show_bug.cgi?id=1829396
     Services.logins.addLogin(login);
     login.QueryInterface(Ci.nsILoginMetaInfo);
     return login.guid;

toolkit/components/passwordmgr/LoginManagerParent.sys.mjs

@@ -1414,7 +1414,9 @@ export class LoginManagerParent extends JSWindowActorParent {
         existingLogin.password = formLogin.password;
       } else if (!autoSavedLogin) {
         lazy.log("Auto-saving new login with empty username.");
-        existingLogin = Services.logins.addLogin(formLoginWithoutUsername);
+        existingLogin = await Services.logins.addLoginAsync(
+          formLoginWithoutUsername
+        );
         // Remember the GUID where we saved the generated password so we can update
         // the login if the user later edits the generated password.
         generatedPW.storageGUID = existingLogin.guid;