Skip to content

Commit 8b2f435

Browse files
committed
Bug 1880452 - Revert to recording FX_NEW_WINDOW_MS only when manually opening a new browser window from an existing one. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D204588
1 parent ac54361 commit 8b2f435

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

browser/base/content/browser.js

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4536,7 +4536,23 @@ function toOpenWindowByType(inType, uri, features) {
45364536
* @return a reference to the new window.
45374537
*/
45384538
function OpenBrowserWindow(options = {}) {
4539-
return BrowserWindowTracker.openWindow({ openerWindow: window, ...options });
4539+
let telemetryObj = {};
4540+
TelemetryStopwatch.start("FX_NEW_WINDOW_MS", telemetryObj);
4541+
4542+
let win = BrowserWindowTracker.openWindow({
4543+
openerWindow: window,
4544+
...options,
4545+
});
4546+
4547+
win.addEventListener(
4548+
"MozAfterPaint",
4549+
() => {
4550+
TelemetryStopwatch.finish("FX_NEW_WINDOW_MS", telemetryObj);
4551+
},
4552+
{ once: true }
4553+
);
4554+
4555+
return win;
45404556
}
45414557

45424558
/**

browser/modules/BrowserWindowTracker.sys.mjs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -287,9 +287,6 @@ export const BrowserWindowTracker = {
287287
remote = undefined,
288288
fission = undefined,
289289
} = {}) {
290-
let telemetryObj = {};
291-
TelemetryStopwatch.start("FX_NEW_WINDOW_MS", telemetryObj);
292-
293290
let windowFeatures = "chrome,dialog=no,all";
294291
if (features) {
295292
windowFeatures += `,${features}`;
@@ -344,7 +341,6 @@ export const BrowserWindowTracker = {
344341
win.addEventListener(
345342
"MozAfterPaint",
346343
() => {
347-
TelemetryStopwatch.finish("FX_NEW_WINDOW_MS", telemetryObj);
348344
if (
349345
Services.prefs.getIntPref("browser.startup.page") == 1 &&
350346
loadURIString == lazy.HomePage.get()

0 commit comments

Comments
 (0)