Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao

Differential Revision: https://phabricator.services.mozilla.com/D202949

Author: Mossop

browser/base/content/aboutDialog-appUpdater.js

@@ -28,7 +28,7 @@ var UPDATING_MIN_DISPLAY_TIME_MS = 1500;
 
 var gAppUpdater;
 
-function onUnload(aEvent) {
+function onUnload(_aEvent) {
   if (gAppUpdater) {
     gAppUpdater.destroy();
     gAppUpdater = null;

browser/base/content/browser-a11yUtils.js

@@ -21,20 +21,16 @@ var A11yUtils = {
    * can thus hinder rather than help users if used incorrectly.
    * Please only use this after consultation with the Mozilla accessibility
    * team.
+   * @param {object} [options]
    * @param {string} [options.id] The Fluent id of the message to announce. The
    *        ftl file must already be included in browser.xhtml. This must be
    *        specified unless a raw message is specified instead.
    * @param {object} [options.args] Arguments for the Fluent message.
    * @param {string} [options.raw] The raw, already localized message to
    *        announce. You should generally prefer a Fluent id instead, but in
    *        rare cases, this might not be feasible.
-   * @param {Element} [options.source] The element with which the announcement
-   *        is associated. This should generally be something the user can
-   *        interact with to respond to the announcement. For example, for an
-   *        announcement indicating that Reader View is available, this should
-   *        be the Reader View button on the toolbar.
    */
-  async announce({ id = null, args = {}, raw = null, source = document } = {}) {
+  async announce({ id = null, args = {}, raw = null } = {}) {
     if ((!id && !raw) || (id && raw)) {
       throw new Error("One of raw or id must be specified.");
     }

browser/base/content/browser-addons.js

@@ -525,7 +525,7 @@ var gXPInstallObserver = {
     Services.console.logMessage(consoleMsg);
   },
 
-  async observe(aSubject, aTopic, aData) {
+  async observe(aSubject, aTopic) {
     var installInfo = aSubject.wrappedJSObject;
     var browser = installInfo.browser;
 
@@ -1009,7 +1009,7 @@ var gExtensionsNotifications = {
 
     let items = 0;
     if (lazy.AMBrowserExtensionsImport.canCompleteOrCancelInstalls) {
-      this._createAddonButton("webext-imported-addons", null, evt => {
+      this._createAddonButton("webext-imported-addons", null, () => {
         lazy.AMBrowserExtensionsImport.completeInstalls();
       });
       items++;
@@ -1022,7 +1022,7 @@ var gExtensionsNotifications = {
       this._createAddonButton(
         "webext-perms-update-menu-item",
         update.addon,
-        evt => {
+        () => {
           ExtensionsUI.showUpdate(gBrowser, update);
         }
       );
@@ -1032,7 +1032,7 @@ var gExtensionsNotifications = {
       if (++items > 4) {
         break;
       }
-      this._createAddonButton("webext-perms-sideload-menu-item", addon, evt => {
+      this._createAddonButton("webext-perms-sideload-menu-item", addon, () => {
         // We need to hide the main menu manually because the toolbarbutton is
         // removed immediately while processing this event, and PanelUI is
         // unable to identify which panel should be closed automatically.
@@ -1117,7 +1117,7 @@ var BrowserAddonUI = {
     win.openAbuseReport({ addonId, reportEntryPoint });
   },
 
-  async removeAddon(addonId, eventObject) {
+  async removeAddon(addonId) {
     let addon = addonId && (await AddonManager.getAddonByID(addonId));
     if (!addon || !(addon.permissions & AddonManager.PERM_CAN_UNINSTALL)) {
       return;
@@ -1136,7 +1136,7 @@ var BrowserAddonUI = {
     }
   },
 
-  async manageAddon(addonId, eventObject) {
+  async manageAddon(addonId) {
     let addon = addonId && (await AddonManager.getAddonByID(addonId));
     if (!addon) {
       return;
@@ -1798,7 +1798,7 @@ var gUnifiedExtensions = {
     }
   },
 
-  onWidgetAdded(aWidgetId, aArea, aPosition) {
+  onWidgetAdded(aWidgetId, aArea) {
     // When we pin a widget to the toolbar from a narrow window, the widget
     // will be overflowed directly. In this case, we do not want to change the
     // class name since it is going to be changed by `onWidgetOverflow()`
@@ -1813,7 +1813,7 @@ var gUnifiedExtensions = {
     this._updateWidgetClassName(aWidgetId, inPanel);
   },
 
-  onWidgetOverflow(aNode, aContainer) {
+  onWidgetOverflow(aNode) {
     // We register a CUI listener for each window so we make sure that we
     // handle the event for the right window here.
     if (window !== aNode.ownerGlobal) {
@@ -1823,7 +1823,7 @@ var gUnifiedExtensions = {
     this._updateWidgetClassName(aNode.getAttribute("widget-id"), true);
   },
 
-  onWidgetUnderflow(aNode, aContainer) {
+  onWidgetUnderflow(aNode) {
     // We register a CUI listener for each window so we make sure that we
     // handle the event for the right window here.
     if (window !== aNode.ownerGlobal) {

browser/base/content/browser-allTabsMenu.js

@@ -58,7 +58,7 @@ var gTabsPanel = {
       dropIndicator: this.dropIndicator,
     });
 
-    this.allTabsView.addEventListener("ViewShowing", e => {
+    this.allTabsView.addEventListener("ViewShowing", () => {
       PanelUI._ensureShortcutsShown(this.allTabsView);
 
       let containersEnabled =
@@ -74,7 +74,7 @@ var gTabsPanel = {
         !hasHiddenTabs;
     });
 
-    this.allTabsView.addEventListener("ViewShown", e =>
+    this.allTabsView.addEventListener("ViewShown", () =>
       this.allTabsView
         .querySelector(".all-tabs-item[selected]")
         ?.scrollIntoView({ block: "center" })
@@ -170,7 +170,7 @@ var gTabsPanel = {
     }
     this.allTabsView.addEventListener(
       "ViewShown",
-      e => {
+      () => {
         PanelUI.showSubView(
           this.kElements.hiddenTabsView,
           this.hiddenTabsButton

browser/base/content/browser-captivePortal.js

@@ -95,7 +95,7 @@ var CaptivePortalWatcher = {
     }
   },
 
-  observe(aSubject, aTopic, aData) {
+  observe(aSubject, aTopic) {
     switch (aTopic) {
       case "captive-portal-login":
         this._captivePortalDetected();

browser/base/content/browser-ctrlTab.js

@@ -284,7 +284,7 @@ var ctrlTab = {
       this.uninit();
     }
   },
-  observe(aSubject, aTopic, aPrefName) {
+  observe() {
     this.readPref();
   },
 
@@ -654,7 +654,7 @@ var ctrlTab = {
         // tab attribute modified (i.e. label, busy, image)
         // update preview only if tab attribute modified in the list
         if (
-          event.detail.changed.some((elem, ind, arr) =>
+          event.detail.changed.some(elem =>
             ["label", "busy", "image"].includes(elem)
           )
         ) {

browser/base/content/browser-data-submission-info-bar.js

@@ -92,7 +92,7 @@ var gDataNotificationInfoBar = {
     }
   },
 
-  observe(subject, topic, data) {
+  observe(subject, topic) {
     switch (topic) {
       case "datareporting:notify-data-policy:request":
         let request = subject.wrappedJSObject.object;

browser/base/content/browser-gestureSupport.js

@@ -269,7 +269,7 @@ var gGestureSupport = {
       gHistorySwipeAnimation.updateAnimation(aEvent.delta);
     };
 
-    this._doEnd = function GS__doEnd(aEvent) {
+    this._doEnd = function GS__doEnd() {
       gHistorySwipeAnimation.swipeEndEventReceived();
 
       this._doUpdate = function () {};
@@ -393,15 +393,15 @@ var gGestureSupport = {
    * @param aEvent
    *        The continual motion update event to handle
    */
-  _doUpdate(aEvent) {},
+  _doUpdate() {},
 
   /**
    * Handle gesture end events.  This function will be set by _setupSwipe.
    *
    * @param aEvent
    *        The gesture end event to handle
    */
-  _doEnd(aEvent) {},
+  _doEnd() {},
 
   /**
    * Convert the swipe gesture into a browser action based on the direction.
@@ -874,7 +874,7 @@ var gHistorySwipeAnimation = {
     }
   },
 
-  _completeFadeOut: function HSA__completeFadeOut(aEvent) {
+  _completeFadeOut: function HSA__completeFadeOut() {
     if (!this._isStoppingAnimation) {
       // The animation was restarted in the middle of our stopping fade out
       // tranistion, so don't do anything.
@@ -943,7 +943,7 @@ var gHistorySwipeAnimation = {
     return element;
   },
 
-  observe(subj, topic, data) {
+  observe(subj, topic) {
     switch (topic) {
       case "nsPref:changed":
         this._initPrefValues();

browser/base/content/browser-pageActions.js

@@ -1008,7 +1008,7 @@ BrowserPageActions.bookmark = {
     }
   },
 
-  onCommand(event, buttonNode) {
+  onCommand(event) {
     PanelMultiView.hidePopup(BrowserPageActions.panelNode);
     BookmarkingUI.onStarCommand(event);
   },

browser/base/content/browser-places.js

@@ -17,7 +17,7 @@ XPCOMUtils.defineLazyPreferenceGetter(
   "SHOW_OTHER_BOOKMARKS",
   "browser.toolbars.bookmarks.showOtherBookmarks",
   true,
-  (aPref, aPrevVal, aNewVal) => {
+  () => {
     BookmarkingUI.maybeShowOtherBookmarksFolder().then(() => {
       document
         .getElementById("PlacesToolbar")
@@ -253,7 +253,7 @@ var StarUI = {
       }
       target.addEventListener(
         "popupshown",
-        function (event) {
+        function () {
           fn();
         },
         { capture: true, once: true }
@@ -1174,7 +1174,7 @@ var PlacesToolbarHelper = {
     return null;
   },
 
-  onWidgetUnderflow(aNode, aContainer) {
+  onWidgetUnderflow(aNode) {
     // The view gets broken by being removed and reinserted by the overflowable
     // toolbar, so we have to force an uninit and reinit.
     let win = aNode.ownerGlobal;
@@ -1183,7 +1183,7 @@ var PlacesToolbarHelper = {
     }
   },
 
-  onWidgetAdded(aWidgetId, aArea, aPosition) {
+  onWidgetAdded(aWidgetId) {
     if (aWidgetId == "personal-bookmarks" && !this._isCustomizing) {
       // It's possible (with the "Add to Menu", "Add to Toolbar" context
       // options) that the Places Toolbar Items have been moved without
@@ -1659,13 +1659,13 @@ var BookmarkingUI = {
     }
   },
 
-  onWidgetReset: function BUI_widgetReset(aNode, aContainer) {
+  onWidgetReset: function BUI_widgetReset(aNode) {
     if (aNode == this.button) {
       this._onWidgetWasMoved();
     }
   },
 
-  onWidgetUndoMove: function BUI_undoWidgetUndoMove(aNode, aContainer) {
+  onWidgetUndoMove: function BUI_undoWidgetUndoMove(aNode) {
     if (aNode == this.button) {
       this._onWidgetWasMoved();
     }
@@ -2155,7 +2155,7 @@ var BookmarkingUI = {
     });
   },
 
-  onWidgetUnderflow(aNode, aContainer) {
+  onWidgetUnderflow(aNode) {
     let win = aNode.ownerGlobal;
     if (aNode.id != this.BOOKMARK_BUTTON_ID || win != window) {
       return;