Skip to content

Commit e6f387a

Browse files
committed
Bug 1876199 - update and add new callouts for rediscoverability experiment. r=shopping-reviewers,aminomancer,fluent-reviewers,bolsson,jhirsch,niklas
Patch changes: - updates the original in-tree callouts 1-3 to run if `autoOpen.enabled` is false, so that they're not affected by the experiment when we flip the pref to true - adds a revised callout 1 for the experiment, this time targeting not opted-in users and gating it behind `autoOpen.enabled` == true - adds a revised callout 3 for the experiment which targets not opted-in users that already saw callout 1 and 24 hours have passed - adds callout 4 that will be used when the user 1) selects "Yes, keep closed" or 2) disables auto-open behaviour via the settings toggle. It is gated behind `autoOpen.enabled` == true - adds callout 5 that will be used when the user opts out of Review Checker via the opt-out button in settings. It is gated behind `autoOpen.enabled` == true Differential Revision: https://phabricator.services.mozilla.com/D200072
1 parent 9afffe8 commit e6f387a

File tree

8 files changed

+551
-25
lines changed

8 files changed

+551
-25
lines changed

browser/components/BrowserGlue.sys.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,6 @@ let JSWINDOWACTORS = {
761761
ReportProductAvailable: { wantUntrusted: true },
762762
AdClicked: { wantUntrusted: true },
763763
AdImpression: { wantUntrusted: true },
764-
ShowCallout4: { wantUntrusted: true },
765764
},
766765
},
767766
matches: ["about:shoppingsidebar"],

browser/components/newtab/lib/FeatureCalloutMessages.sys.mjs

Lines changed: 408 additions & 6 deletions
Large diffs are not rendered by default.

browser/components/shopping/ShoppingSidebarChild.sys.mjs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,6 @@ export class ShoppingSidebarChild extends RemotePageChild {
165165
ShoppingProduct.sendAttributionEvent("impression", aid);
166166
Glean.shopping.surfaceAdsImpression.record();
167167
break;
168-
case "ShowCallout4":
169-
this.sendAsyncMessage("Shopping:SendTrigger", {
170-
id: "shoppingAutoOpenUserDisabled", // TODO: update this in bug 1874949
171-
});
172-
break;
173168
}
174169
}
175170

browser/components/shopping/ShoppingSidebarParent.sys.mjs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,6 @@ export class ShoppingSidebarParent extends JSWindowActorParent {
5151
"browser[messagemanagergroup=browsers]"
5252
);
5353
return associatedTabbedBrowser.currentURI?.spec ?? null;
54-
case "Shopping:SendTrigger":
55-
let trigger = message.data;
56-
if (!trigger.browser) {
57-
trigger.browser =
58-
this.browsingContext.topChromeWindow.gBrowser.selectedBrowser;
59-
}
60-
lazy.ShoppingUtils.sendTrigger(message.data);
6154
}
6255
return null;
6356
}
Lines changed: 41 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)