Skip to content

Conversation

headlessNode
Copy link
Member

What is the purpose of this pull request?

This pull request:

  • add top-level implementation of map function for @stdlib/ndarray

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@headlessNode headlessNode added the Feature Issue or pull request for adding a new feature. label Dec 2, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 2, 2024

Coverage Report

Package Statements Branches Functions Lines
ndarray/map $\color{green}180/180$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}180/180$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode marked this pull request as ready for review December 4, 2024 06:26
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 4, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 13, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @headlessNode. Did a bit of clean-up. This now LGTM.

@kgryte kgryte added the Ready To Merge A pull request which is ready to be merged. label Dec 13, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `ndarray/map`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3314
Ref: https://github.com/stdlib-js/stdlib/issues/2656

Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@kgryte kgryte merged commit 3ea906b into stdlib-js:develop Dec 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants