Skip to content

Tiled vae parameter validation #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2025
Merged

Tiled vae parameter validation #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99616b9
avoid crash with invalid tile sizes, use 0 for default
wbruna Sep 12, 2025
570e26a
refactor default tile size, limit overlap factor
wbruna Sep 12, 2025
06b4130
remove explicit parameter for relative tile size
wbruna Sep 12, 2025
0e56bc7
limit encoding tile to latent size
wbruna Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions examples/cli/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ struct SDParams {
int chroma_t5_mask_pad = 1;
float flow_shift = INFINITY;

sd_tiling_params_t vae_tiling_params = {false, 32, 32, 0.5f, false, 0.0f, 0.0f};
sd_tiling_params_t vae_tiling_params = {false, 0, 0, 0.5f, 0.0f, 0.0f};

SDParams() {
sd_sample_params_init(&sample_params);
Expand Down Expand Up @@ -749,7 +749,6 @@ void parse_args(int argc, const char** argv, SDParams& params) {
} catch (const std::out_of_range& e) {
return -1;
}
params.vae_tiling_params.relative = false;
return 1;
};

Expand All @@ -773,7 +772,6 @@ void parse_args(int argc, const char** argv, SDParams& params) {
} catch (const std::out_of_range& e) {
return -1;
}
params.vae_tiling_params.relative = true;
return 1;
};

Expand Down
72 changes: 33 additions & 39 deletions stable-diffusion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class StableDiffusionGGML {

std::string taesd_path;
bool use_tiny_autoencoder = false;
sd_tiling_params_t vae_tiling_params = {false, 32, 32, 0.5f, false, 0, 0};
sd_tiling_params_t vae_tiling_params = {false, 0, 0, 0.5f, 0, 0};
bool offload_params_to_cpu = false;
bool stacked_id = false;

Expand Down Expand Up @@ -1300,27 +1300,30 @@ class StableDiffusionGGML {
return latent;
}

void get_relative_tile_sizes(int& tile_size_x, int& tile_size_y, float tile_overlap, float rel_size_x, float rel_size_y, int latent_x, int latent_y) {
// format is AxB, or just A (equivalent to AxA)
// A and B can be integers (tile size) or floating point
// floating point <= 1 means simple fraction of the latent dimension
// floating point > 1 means number of tiles across that dimension
// a single number gets applied to both
auto get_tile_factor = [tile_overlap](float factor) {
if (factor > 1.0)
factor = 1 / (factor - factor * tile_overlap + tile_overlap);
return factor;
};
const int min_tile_dimension = 4;

int tmp_x = tile_size_x, tmp_y = tile_size_y;
tmp_x = std::round(latent_x * get_tile_factor(rel_size_x));
tmp_y = std::round(latent_y * get_tile_factor(rel_size_y));

tile_size_x = std::max(std::min(tmp_x, latent_x), min_tile_dimension);
tile_size_y = std::max(std::min(tmp_y, latent_y), min_tile_dimension);
void get_tile_sizes(int& tile_size_x, int& tile_size_y, float& tile_overlap, const sd_tiling_params_t & params,
int latent_x, int latent_y, float encoding_factor = 1.0f) {
tile_overlap = std::max(std::min(params.target_overlap, 0.5f), 0.0f);
auto get_tile_size = [&](int requested_size, float factor, int latent_size) {
const int default_tile_size = 32;
const int min_tile_dimension = 4;
int tile_size = default_tile_size;
// rel_size <= 1 means simple fraction of the latent dimension
// rel_size > 1 means number of tiles across that dimension
if (factor > 0.f) {
if (factor > 1.0)
factor = 1 / (factor - factor * tile_overlap + tile_overlap);
tile_size = std::round(latent_size * factor);
}
else if (requested_size >= min_tile_dimension) {
tile_size = requested_size;
}
tile_size *= encoding_factor;
return std::max(std::min(tile_size, latent_size), min_tile_dimension);
};

LOG_INFO("VAE Tile size: %dx%d", tile_size_x, tile_size_y);
tile_size_x = get_tile_size(params.tile_size_x, params.rel_size_x, latent_x);
tile_size_y = get_tile_size(params.tile_size_y, params.rel_size_y, latent_y);
}

ggml_tensor* encode_first_stage(ggml_context* work_ctx, ggml_tensor* x, bool decode_video = false) {
Expand All @@ -1336,20 +1339,14 @@ class StableDiffusionGGML {
}
result = ggml_new_tensor_4d(work_ctx, GGML_TYPE_F32, W, H, C, x->ne[3]);
}
// TODO: args instead of env for tile size / overlap?
if (!use_tiny_autoencoder) {
float tile_overlap = vae_tiling_params.target_overlap;
int tile_size_x = vae_tiling_params.tile_size_x;
int tile_size_y = vae_tiling_params.tile_size_y;

if (vae_tiling_params.relative) {
get_relative_tile_sizes(tile_size_x, tile_size_y, tile_overlap, vae_tiling_params.rel_size_x, vae_tiling_params.rel_size_y, W, H);
}

// TODO: also use an arg for this one?
if (!use_tiny_autoencoder) {
float tile_overlap;
int tile_size_x, tile_size_y;
// multiply tile size for encode to keep the compute buffer size consistent
tile_size_x *= 1.30539;
tile_size_y *= 1.30539;
get_tile_sizes(tile_size_x, tile_size_y, tile_overlap, vae_tiling_params, W, H, 1.30539);

LOG_DEBUG("VAE Tile size: %dx%d", tile_size_x, tile_size_y);

process_vae_input_tensor(x);
if (vae_tiling_params.enabled && !decode_video) {
Expand Down Expand Up @@ -1489,13 +1486,10 @@ class StableDiffusionGGML {
}
int64_t t0 = ggml_time_ms();
if (!use_tiny_autoencoder) {
float tile_overlap = vae_tiling_params.target_overlap;
int tile_size_x = vae_tiling_params.tile_size_x;
int tile_size_y = vae_tiling_params.tile_size_y;
float tile_overlap;
int tile_size_x, tile_size_y;
get_tile_sizes(tile_size_x, tile_size_y, tile_overlap, vae_tiling_params, W, H);

if (vae_tiling_params.relative) {
get_relative_tile_sizes(tile_size_x, tile_size_y, tile_overlap, vae_tiling_params.rel_size_x, vae_tiling_params.rel_size_y, x->ne[0], x->ne[1]);
}
LOG_DEBUG("VAE Tile size: %dx%d", tile_size_x, tile_size_y);

process_latent_out(x);
Expand Down Expand Up @@ -1769,7 +1763,7 @@ void sd_img_gen_params_init(sd_img_gen_params_t* sd_img_gen_params) {
sd_img_gen_params->control_strength = 0.9f;
sd_img_gen_params->style_strength = 20.f;
sd_img_gen_params->normalize_input = false;
sd_img_gen_params->vae_tiling_params = {false, 32, 32, 0.5f, false, 0.0f, 0.0f};
sd_img_gen_params->vae_tiling_params = {false, 0, 0, 0.5f, 0.0f, 0.0f};
}

char* sd_img_gen_params_to_str(const sd_img_gen_params_t* sd_img_gen_params) {
Expand Down
1 change: 0 additions & 1 deletion stable-diffusion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ typedef struct {
int tile_size_x;
int tile_size_y;
float target_overlap;
bool relative;
float rel_size_x;
float rel_size_y;
} sd_tiling_params_t;
Expand Down
Loading