Skip to content

Conversation

@overcat
Copy link
Member

@overcat overcat commented Jul 4, 2025

No description provided.

@overcat overcat requested a review from Copilot July 4, 2025 11:46

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (add-protocol23-support@f3ca385). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/main/java/org/stellar/sdk/StrKey.java 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             add-protocol23-support     #701   +/-   ##
=========================================================
  Coverage                          ?   80.29%           
  Complexity                        ?     1244           
=========================================================
  Files                             ?      213           
  Lines                             ?     4898           
  Branches                          ?      416           
=========================================================
  Hits                              ?     3933           
  Misses                            ?      708           
  Partials                          ?      257           
Files with missing lines Coverage Δ
src/main/java/org/stellar/sdk/Address.java 75.55% <100.00%> (ø)
src/main/java/org/stellar/sdk/StrKey.java 90.29% <89.47%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@overcat overcat requested a review from Copilot July 4, 2025 11:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Stellar liquidity pool and claimable balance strkeys by extending the core encoding/decoding utilities and adding validation methods, plus tests.

  • Introduces encodeLiquidityPool, decodeLiquidityPool, isValidLiquidityPool and their claimable balance counterparts.
  • Updates VersionByte enum and decodeCheck to validate claimable balance payload length.
  • Adds unit tests covering encode/decode and validity checks for both new strkey types.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/main/java/org/stellar/sdk/StrKey.java Added new encoding/decoding and validation methods for liquidity pool (L...) and claimable balance (B...), plus enum updates.
src/main/java/org/stellar/sdk/Address.java Updated SCAddress contract handling to use the new ContractID wrapper API (getContractID()).
src/test/java/org/stellar/sdk/StrKeyTest.java Added tests for encoding/decoding and validity checks of liquidity pool and claimable balance strkeys.

@overcat overcat merged commit 6e57ab1 into add-protocol23-support Jul 4, 2025
7 checks passed
@overcat overcat deleted the p23-strkey branch July 4, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants