Update soroban-rpc to use a config file #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
tamirms
reviewed
May 2, 2023
leighmcculloch
approved these changes
May 2, 2023
|
@paulbellamy one of the tests is failing with the following error message: https://github.com/stellar/quickstart/actions/runs/4863896931/jobs/8672481761?pr=444 |
|
Oh, the tools_ref in the github CI is pointing to 0.7.0. This isn't critical, so let's delay merging this until after the soroban-rpc 0.8.0 release. |
sreuland
reviewed
May 3, 2023
sreuland
reviewed
May 3, 2023
sreuland
approved these changes
May 3, 2023
|
This PR should not be merged until we release the soroban-rpc and update it's dependency here. then, we should be able to update this and it should pass all the tests. |
|
will update this to use soroban-tools tagged release version for preview9 when out and then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new
--config-pathflag from stellar/stellar-cli#609