Release/1.2.0 #177
Merged
Release/1.2.0 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What Support SEP-8 "Action Required" flow. Closes #113 ### Future Work The action fields received in the action required responses are all being handled as strings for now. I'll update this behavior to accept different kinds of inputs in the future, since the [SEP-9] field types can include "string", "country code", "phone number", date", "number" or "binary". [SEP-9]: https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0009.md ### Screenshot https://user-images.githubusercontent.com/1952597/119165154-958bd600-ba33-11eb-9639-3d014c8003d4.mov ### How to test Use the jenkins preview link with `/account?secretKey=SBQZPYFQNQD4B7MP7PC3NKCMS5G5LD6PVO7BUYC34M4BBFN6KCXSKSVD` and send a small payment to `GBID36ML6VVNPIF6SQATQW5QIBREQAVEHQIUMWDLQCSVIYX2IJGK4KPP`. #### KYC Approval Criteria * Emails starting with "x" will get rejected * Emails not starting with "x" will get approved. If you need to repeat your tests you might need to delete the KYC already stored in the server with: ```curl curl -X DELETE https://sep8-server.dev.stellar.org/kyc-status/GASA5HCKMDAPLB6NIV7ADDA6YMTAQ2555TXKMS7FSVO44TJXHEGXLICZ ```
* add Sep-6 deposit flow * fix typo * adding bad input handling for deposit choice * reorder import * rm unneeded eslint disable * memoize depositTypes choices * PR comments
* add Sep-6 deposit flow * fix typo * adding bad input handling for deposit choice * reorder import * rm unneeded eslint disable * memoize depositTypes choices * PR comments * Add withdraw flow for sep-6 * rm console logs * update sep6 schemas to match other sep's * PR comments
* GitHub link in footer * Remove announcement banner
### What Add instructions to Test SEP-8 Payments in the Demo Wallet using our SEP-8 reference server sep8-server.dev.stellar.org. Closes #160
* upgrading stellar-sdk and adding optional muxed acct support * update TransactionBuilder to use new params
* add Sep-6 deposit flow * fix typo * adding bad input handling for deposit choice * reorder import * rm unneeded eslint disable * memoize depositTypes choices * PR comments * Add withdraw flow for sep-6 * rm console logs * first pass at claimable balance for deposit * update sep6 schemas to match other sep's * add withdraw claimable balance path * add amount field to withdraw * add untrusted asset flow * add better message for withdraw flow * rm console logs * rm unneeded dep and const explanation * rm unneccessary check * rm <InfoBlock> and replace with <div>
### What Fix SEP-8 action_required return condition. ### Why The code was using the wrong condition check.
…se (#175) ### What Support all SEP-9 fields when handling SEP-8 "action_required" response. ### Why In order to have a complete implementation of SEP-8 we should be able to send binary and date fields as well.
### What Support SEP-8 "action_required" responses with GET action methods. ### Why We were only supporting SEP-8 responses with POST action methods, which is not the default response according with the SEP.
|
Preview is available here: |
### What Add description explaining the Demo Wallet keypair represents the Sending Anchor when we're demo-ing SEP-31. Added to Readme.md and to the SEP-31 modal. ### Why In all other use cases for the Demo Wallet, the keypair actually represents a client's account, SEP-31 is the only exception.
…ing" response (#187) ### What Fix log when receiving an empty (or "0") timestamp from a SEP-8 "pending" response. ### Why It's possible to receive `timestamp: 0` from a "pending" SEP-8 response and we were not handling that case. Ref: https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0008.md#pending
|
Preview is available here: |
* SEP-12 customer fields status check * Adjust rejected status * Cleanup
|
Preview is available here: |
* Do not show actions for untrusted regulated assets * Add extra check
* SEP-6 deposit amount added * SEP-6 deposit start polling button * Text updates * Change deposit success modal title
|
Preview is available here: |
### Changes * After getting the KYC approved, send the user straight to the “review & submit” modal. * Update the “Review & Submit” modal text to “`KYC has been approved.` Please review the updated operations before submitting your SEP-8 payment.” * Update the log message when resubmitting payment automatically. ### Preview https://user-images.githubusercontent.com/1952597/124181606-1ce55400-da8c-11eb-8fb3-3c8adb917f13.mov
Addition to SEP-08 instructions and added to the roadmap
* Updated readme with release notes modified: README.md * Reversed the order for release notes
shanzzam
approved these changes
Jul 7, 2021
quietbits
approved these changes
Jul 7, 2021
marcelosalloum
added a commit
that referenced
this pull request
Jul 19, 2021
This reverts commit 790e8ba.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog