Skip to content

Commit 7612fa0

Browse files
committed
fix(angular): do not emit proxies for internal APIs
1 parent 262c499 commit 7612fa0

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

src/compiler/distribution/dist-angular.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,18 +206,20 @@ export class ${tagNameAsPascal} {`];
206206
function getInputs(cmpMeta: d.ComponentMeta) {
207207
return Object.keys(cmpMeta.membersMeta || {}).filter(memberName => {
208208
const m = cmpMeta.membersMeta[memberName];
209-
return m.memberType === MEMBER_TYPE.Prop || m.memberType === MEMBER_TYPE.PropMutable;
209+
return isPublic(m.jsdoc) && (m.memberType === MEMBER_TYPE.Prop || m.memberType === MEMBER_TYPE.PropMutable);
210210
});
211211
}
212212

213213
function getOutputs(cmpMeta: d.ComponentMeta) {
214-
return (cmpMeta.eventsMeta || []).map(eventMeta => eventMeta.eventName);
214+
return (cmpMeta.eventsMeta || [])
215+
.filter(e => isPublic(e.jsdoc))
216+
.map(eventMeta => eventMeta.eventName);
215217
}
216218

217219
function getMethods(cmpMeta: d.ComponentMeta) {
218220
return Object.keys(cmpMeta.membersMeta || {}).filter(memberName => {
219221
const m = cmpMeta.membersMeta[memberName];
220-
return m.memberType === MEMBER_TYPE.Method;
222+
return isPublic(m.jsdoc) && m.memberType === MEMBER_TYPE.Method;
221223
});
222224
}
223225

@@ -242,3 +244,7 @@ export const DIRECTIVES = [
242244
];
243245
`;
244246
}
247+
248+
function isPublic(jsDocs: d.JsDoc | undefined) {
249+
return !!(jsDocs && !jsDocs.tags.some((s) => s.name === 'internal'));
250+
}

0 commit comments

Comments
 (0)