feat(compiler): watch *.html files (#1531)

* feat(compiler):  watch  *.html files

* Update fs-watch-rebuild.spec.ts

* Update fs-watch-rebuild.spec.ts

Author: romulocintra

src/compiler/build/build-ctx.ts

@@ -31,7 +31,7 @@ export class BuildContext implements d.BuildCtx {
   hasConfigChanges = false;
   hasCopyChanges = false;
   hasFinished = false;
-  hasIndexHtmlChanges = false;
+  hasHtmlChanges = false;
   hasPrintedResults = false;
   hasServiceWorkerChanges = false;
   hasScriptChanges = true;

src/compiler/build/build-hmr.ts

@@ -26,7 +26,7 @@ export function generateHmr(config: d.Config, compilerCtx: d.CompilerCtx, buildC
     hmr.excludeHmr = excludeHmr.slice();
   }
 
-  if (buildCtx.hasIndexHtmlChanges) {
+  if (buildCtx.hasHtmlChanges) {
     hmr.indexHtmlUpdated = true;
   }
 

src/compiler/fs-watch/fs-watch-rebuild.ts

@@ -47,7 +47,7 @@ export function generateBuildFromFsWatch(config: d.Config, compilerCtx: d.Compil
   buildCtx.hasStyleChanges = hasStyleChanges(buildCtx);
 
   // figure out if any changed files were index.html files
-  buildCtx.hasIndexHtmlChanges = hasIndexHtmlChanges(config, buildCtx);
+  buildCtx.hasHtmlChanges = hasHtmlChanges(config, buildCtx);
 
   buildCtx.hasServiceWorkerChanges = hasServiceWorkerChanges(config, buildCtx);
 
@@ -164,10 +164,11 @@ export function isStyleExt(ext: string) {
 const STYLE_EXT = ['css', 'scss', 'sass', 'pcss', 'styl', 'stylus', 'less'];
 
 
-function hasIndexHtmlChanges(config: d.Config, buildCtx: d.BuildCtx) {
-  const anyIndexHtmlChanged = buildCtx.filesChanged.some(fileChanged => config.sys.path.basename(fileChanged).toLowerCase() === 'index.html');
-  if (anyIndexHtmlChanged) {
-    // any index.html in any directory that changes counts too
+function hasHtmlChanges(config: d.Config, buildCtx: d.BuildCtx) {
+  const anyHtmlChanged = buildCtx.filesChanged.some(f => f.toLowerCase().endsWith('.html'));
+  
+  if (anyHtmlChanged) {
+    // any *.html in any directory that changes counts and rebuilds
     return true;
   }
 

src/compiler/fs-watch/test/fs-watch-rebuild.spec.ts

@@ -51,6 +51,13 @@ describe('fs-watch, rebuild', () => {
     expect(buildCtx.hasStyleChanges).toBe(true);
   });
 
+  it('hasHtmlChanges', () => {
+    compilerCtx.activeFilesUpdated = ['file.HTML', 'file2.html'];
+    const buildCtx = generateBuildFromFsWatch(config, compilerCtx);
+    expect(buildCtx).toBeDefined();
+    expect(buildCtx.hasHtmlChanges).toBe(true);
+  });
+
   it('should rebuild for dirsAdded, and recursive add files/dirs', async () => {
     const root = path.resolve('/');
     await compilerCtx.fs.disk.mkdir(path.join(root, 'added-1'));

src/compiler/output-targets/output-utils.ts

@@ -118,7 +118,7 @@ export function canSkipAppCoreBuild(buildCtx: d.BuildCtx) {
   if (buildCtx.requiresFullBuild) {
     return false;
   }
-  if (buildCtx.isRebuild && (buildCtx.hasScriptChanges || buildCtx.hasStyleChanges || buildCtx.hasIndexHtmlChanges)) {
+  if (buildCtx.isRebuild && (buildCtx.hasScriptChanges || buildCtx.hasStyleChanges || buildCtx.hasHtmlChanges)) {
     return false;
   }
   return true;

src/compiler/output-targets/output-www.ts

@@ -83,8 +83,9 @@ function generateHostConfig(config: d.Config, compilerCtx: d.CompilerCtx, output
   return compilerCtx.fs.writeFile(hostConfigPath, hostConfigContent);
 }
 
+
 async function generateIndexHtml(config: d.Config, compilerCtx: d.CompilerCtx, buildCtx: d.BuildCtx, criticalPath: string[], outputTarget: d.OutputTargetWww) {
-  if (compilerCtx.hasSuccessfulBuild && !buildCtx.hasIndexHtmlChanges) {
+  if (compilerCtx.hasSuccessfulBuild && !buildCtx.hasHtmlChanges) {
     // no need to rebuild index.html if there were no app file changes
     return;
   }

src/declarations/build.ts

@@ -49,7 +49,7 @@ export interface BuildCtx {
   hasCopyChanges: boolean;
   hasError: boolean;
   hasFinished: boolean;
-  hasIndexHtmlChanges: boolean;
+  hasHtmlChanges: boolean;
   hasPrintedResults: boolean;
   hasServiceWorkerChanges: boolean;
   hasScriptChanges: boolean;