fix(bundling): fix bundling node resolved import when using browser entry

Closes #1185

Author: adamdbradley

src/compiler/app/app-global-scripts.ts

@@ -95,6 +95,7 @@ async function bundleProjectGlobal(config: Config, compilerCtx: CompilerCtx, bui
           jsnext: true,
           main: true
         }),
+        config.sys.rollup.plugins.emptyJsResolver(),
         config.sys.rollup.plugins.commonjs({
           include: 'node_modules/**',
           sourceMap: false

src/compiler/bundle/rollup-bundle.ts

@@ -58,6 +58,7 @@ export async function createBundle(config: d.Config, compilerCtx: d.CompilerCtx,
         values: replaceObj
       }),
       config.sys.rollup.plugins.nodeResolve(nodeResolveConfig),
+      config.sys.rollup.plugins.emptyJsResolver(),
       config.sys.rollup.plugins.commonjs(commonjsConfig),
       bundleJson(config),
       inMemoryFsRead(config, compilerCtx, buildCtx, entryModules),

src/declarations/system.ts

@@ -37,12 +37,7 @@ export interface StencilSystem {
   path?: Path;
   requestLatestCompilerVersion?(): Promise<string>;
   resolveModule?(fromDir: string, moduleId: string): string;
-  rollup?: {
-    rollup: {
-      (config: any): Promise<any>;
-    };
-    plugins: {[pluginName: string]: any};
-  };
+  rollup?: RollupInterface;
   scopeCss?: (cssText: string, scopeId: string, hostScopeId: string, slotScopeId: string) => Promise<string>;
   semver?: Semver;
   storage?: Storage;
@@ -60,6 +55,18 @@ export interface StencilSystem {
 }
 
 
+export interface RollupInterface {
+  rollup: {
+    (config: any): Promise<any>;
+  };
+  plugins: {
+    nodeResolve(opts: any): any;
+    emptyJsResolver(): any;
+    commonjs(opts: any): any;
+  };
+}
+
+
 export interface Semver {
   lt(v1: string, v2: string): boolean;
   lte(v1: string, v2: string): boolean;

src/sys/node/node-rollup.ts

@@ -1,12 +1,23 @@
 import { rollup } from 'rollup';
 import commonjs from 'rollup-plugin-commonjs';
 import nodeResolve from 'rollup-plugin-node-resolve';
+import path from 'path';
 
 
 export const NodeRollup = {
   rollup,
   plugins: {
     commonjs,
-    nodeResolve
+    nodeResolve,
+    emptyJsResolver: () => {
+      return {
+        load(id: string) {
+          if (id.endsWith('empty.js') && id.endsWith(path.join(__dirname, '../src/empty.js'))) {
+            return 'export default {};';
+          }
+          return null;
+        }
+      };
+    }
   }
 };