Skip to content

Conversation

@ericcornelissen
Copy link
Contributor

This adds a YAML file to describe token permissions and outbound endpoints needed for the Action: ericcornelissen/svgo-action

I would've wanted to add contents-if and pull-requests-if as the token is only needed if ericcornelissen/svgo-action is used on: push or on: pull-request (resp.). But I was unsure how the encode that in the <scope>-if syntax.

References:

@codecov-commenter
Copy link

Codecov Report

Merging #1152 (e9a9d79) into main (d1a1cae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1152   +/-   ##
=======================================
  Coverage   57.52%   57.52%           
=======================================
  Files          14       14           
  Lines        1342     1342           
=======================================
  Hits          772      772           
  Misses        508      508           
  Partials       62       62           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@varunsh-coder
Copy link
Member

Thanks @ericcornelissen for the PR!

We don't have a feature to add condition based on on: attribute as of now.

I have created an issue for it, and will see if there are more scenarios where such a condition might be useful. If so, we can prioritize implementing it. Thanks!

@varunsh-coder varunsh-coder merged commit 396a93c into step-security:main Sep 13, 2022
@ericcornelissen ericcornelissen deleted the add-svgo-action-to-kb branch September 13, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants