Skip to content

Support spaces in attribute values #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Support spaces in attribute values #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
568bca2
Add a [failing] test to reproduce #13
stevegrunwell Mar 24, 2018
236b685
Add another selector test to see if #13 impacts that as well (it does…
stevegrunwell Mar 24, 2018
5d1bcd5
Update the minimum version of zendframework/zend-dom to 2.7 and add a…
stevegrunwell Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]

* Bumped the minimum version of zendframework/zend-dom to 2.7, which includes a fix for attribute values that include spaces ([#13]).

## [1.1.0] - 2018-01-14

* Added the `assertElementContains()`, `assertElementNotContains()`, `assertElementRegExp()`, and `assertElementNotRegExp()` assertions, for verifying the contents of elements that match the given DOM query ([#6]).
Expand All @@ -23,3 +27,4 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
[#7]: https://github.com/stevegrunwell/phpunit-markup-assertions/issues/7
[#8]: https://github.com/stevegrunwell/phpunit-markup-assertions/issues/8
[#9]: https://github.com/stevegrunwell/phpunit-markup-assertions/issues/9
[#13]: https://github.com/stevegrunwell/phpunit-markup-assertions/issues/13
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"source": "https://github.com/stevegrunwell/phpunit-markup-assertions/"
},
"require": {
"zendframework/zend-dom": "^2.2.5"
"zendframework/zend-dom": "^2.7"
},
"require-dev": {
"phpunit/phpunit": ">=6.0"
Expand Down
22 changes: 22 additions & 0 deletions tests/MarkupAssertionsTraitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,19 @@ public function testAssertHasElementWithAttributes()
);
}

/**
* @link https://github.com/stevegrunwell/phpunit-markup-assertions/issues/13
*/
public function testAssertHasElementWithAttributesWithSpacesInTheAttributeValue()
{
$this->testcase->assertHasElementWithAttributes(
[
'data-attr' => 'foo bar baz',
],
'<div data-attr="foo bar baz">Contents</div>'
);
}

public function testAssertNotHasElementWithAttributes()
{
$this->testcase->assertNotHasElementWithAttributes(
Expand All @@ -92,6 +105,15 @@ public function testAssertElementContains()
);
}

public function testAssertElementContainsMultipleSelectors()
{
$this->testcase->assertElementContains(
'ipsum',
'#main .foo',
'<div id="main"><span class="foo">Lorem ipsum</span></div>'
);
}

public function testAssertElementContainsScopesToSelector()
{
$this->expectException(AssertionFailedError::class);
Expand Down