Add dynamic framework target (Carthage) #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| DYLIB_COMPATIBILITY_VERSION = 1; | ||
| DYLIB_CURRENT_VERSION = 39; | ||
| FRAMEWORK_VERSION = A; | ||
| GCC_OPTIMIZATION_LEVEL = 0; |
Collaborator
There was a problem hiding this comment.
I suspect this is not required? Could we leave this to the default please?
Contributor
Author
There was a problem hiding this comment.
This setting is only in the Debug configuration. Otherwise it's hard to debug if you consume the framework via Carthage.
Release is still default Fastest, Smallest [-Os].
Collaborator
|
I believe (but can't confirm at the moment) that the test failures are due to your removal of XCTest dependencies? |
* Adjust Travis CI configuration
Current coverage is 87.72%
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Carthage compatible dynamic framework target #203.
The resulting artifact is
SBJson4.framework.In order to have consistent targets, I've renamed the Mac target to SBJson4-Mac.
@stig please review and tag the release
v4.0.3