Implement accessing files over ACP #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No custom formatter is run, but if the ACP client performs format-on-save, we use it to update the edit tool's input parameters.
... when inputs have changed after executing a tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the "review changes" UI in Zed. When Zed is configured for format-on-save, code-assistant will automatically benefit from this, i.e. both the tool call block in the agent panel as well as the agent's message history are updated to reflect the formatted code in the tool inputs as if the model had produced the correctly formatted code in the first place. That means the model's mental state of a file does not diverge from the actual file's contents on disk.