Skip to content

Conversation

@daniel-white
Copy link

increases the amount of attempts for suggestKey

@daniel-white daniel-white requested review from a team and brendarearden and removed request for a team August 29, 2023 14:09
Copy link

@chohmann chohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change for? Is it really ok to increase this by 50x?

@daniel-white
Copy link
Author

What is this change for? Is it really ok to increase this by 50x?

https://github.com/stoplightio/platform-internal/issues/17764 - i tried with 2000 originally and had no problems

Copy link

@chohmann chohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea if there are any other implications to this change, but if it fixes that high priority bug, then 🤷‍♀️

@mmarti21 mmarti21 merged commit 6e6ba8c into master Aug 29, 2023
@mmarti21 mmarti21 deleted the fix/increase-key-attempts branch August 29, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants