Skip to content

Commit 5fe8224

Browse files
committed
fix: remove height 100 from outer container
BREAKING CHANGE: consumers of JsonSchemaViewer are expected to control its height. It no longer has height: 100% on its outer element
1 parent ad7127e commit 5fe8224

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,17 @@
3636
},
3737
"peerDependencies": {
3838
"@stoplight/markdown-viewer": "^3",
39-
"@stoplight/tree-list": "^4",
40-
"@stoplight/ui-kit": "^2",
39+
"@stoplight/ui-kit": "^3",
4140
"mobx": "^5",
4241
"react": ">=16.8",
4342
"react-dom": ">=16.8"
4443
},
4544
"dependencies": {
4645
"@stoplight/json": "^3.5.1",
46+
"@stoplight/json-schema-merge-allof": "^0.6.0",
4747
"@stoplight/react-error-boundary": "^1.0.0",
48-
"@stoplight/tree-list": "5.0.0-beta.2",
48+
"@stoplight/tree-list": "file:.yalc/@stoplight/tree-list",
4949
"classnames": "^2.2.6",
50-
"@stoplight/json-schema-merge-allof": "^0.6.0",
5150
"lodash": "^4.17.15",
5251
"mobx-react-lite": "^1.4.1",
5352
"pluralize": "^8.0.0"
@@ -60,7 +59,7 @@
6059
"@stoplight/scripts": "^8.2.0",
6160
"@stoplight/storybook-config": "^2.0.5",
6261
"@stoplight/types": "11.0.0",
63-
"@stoplight/ui-kit": "^2.10.0",
62+
"@stoplight/ui-kit": "3.0.0-beta.2",
6463
"@types/classnames": "^2.2.9",
6564
"@types/enzyme": "3.10.3",
6665
"@types/jest": "^24.0.18",

src/__stories__/JsonSchemaViewer.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,9 @@ storiesOf('JsonSchemaViewer', module)
130130
},
131131
address: {
132132
type: [
133+
// @ts-ignore
133134
'null',
135+
// @ts-ignore
134136
{
135137
type: 'object',
136138
properties: {

src/components/JsonSchemaViewer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export class JsonSchemaViewerComponent extends React.PureComponent<IJsonSchemaVi
104104
}
105105

106106
return (
107-
<div className={cn(className, 'JsonSchemaViewer flex flex-col h-full w-full relative')}>
107+
<div className={cn(className, 'JsonSchemaViewer flex flex-col relative')}>
108108
<SchemaTreeComponent expanded={expanded} name={name} schema={schema} treeStore={this.treeStore} {...props} />
109109
</div>
110110
);

src/components/shared/Caret.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export const Caret: React.FunctionComponent<ICaret> = ({ style, size, isExpanded
1616
<Icon
1717
iconSize={size}
1818
icon={isExpanded ? 'caret-down' : 'caret-right'}
19-
className="text-darken-9 dark:text-lighten-9"
19+
className="text-darken-9 dark:text-lighten-7"
2020
/>
2121
</span>
2222
);

0 commit comments

Comments
 (0)