fix: generate unique id for each node (#57)

Author: P0lip

src/utils/__tests__/assignId.spec.ts

@@ -1,6 +1,6 @@
-import { assignId } from '../assignId';
+import { generateId } from '../generateId';
 
-describe('assignId util', () => {
+describe('generateId util', () => {
   let mathRandomSpy: jest.SpyInstance;
 
   beforeEach(() => {
@@ -14,16 +14,7 @@ describe('assignId util', () => {
   test('should generate random id', () => {
     mathRandomSpy.mockReturnValueOnce(0.54444).mockReturnValueOnce(0.321);
 
-    expect(assignId({})).toEqual('0.jlle4v0fcep');
-    expect(assignId({})).toEqual('0.bk0kqhutdje');
-  });
-
-  test('should return previously stored id for same node', () => {
-    mathRandomSpy.mockReturnValueOnce(0.23);
-
-    const node = {};
-    const id = assignId(node);
-
-    expect(assignId(node)).toEqual(id);
+    expect(generateId()).toEqual('0.jlle4v0fcep');
+    expect(generateId()).toEqual('0.bk0kqhutdje');
   });
 });

src/utils/__tests__/renderSchema.spec.ts

@@ -4,8 +4,8 @@ import { renderSchema } from '../renderSchema';
 
 const BASE_PATH = path.resolve(__dirname, '../../__fixtures__/');
 
-jest.mock('../assignId', () => ({
-  assignId: jest.fn(() => 'random-id'),
+jest.mock('../generateId', () => ({
+  generateId: jest.fn(() => 'random-id'),
 }));
 
 describe('renderSchema util', () => {

src/utils/assignId.ts

@@ -0,0 +1 @@
+export const generateId = (): string => Math.random().toString(36);

src/utils/generateId.ts

@@ -8,7 +8,7 @@ import {
   SchemaKind,
   SchemaNode,
 } from '../types';
-import { assignId } from './assignId';
+import { generateId } from './generateId';
 import { getAnnotations } from './getAnnotations';
 import { getPrimaryType } from './getPrimaryType';
 import { getValidations } from './getValidations';
@@ -35,7 +35,7 @@ function processNode(node: JSONSchema4): SchemaNode | void {
 
   if (combiner) {
     return {
-      id: assignId(node),
+      id: generateId(),
       combiner,
       properties: node[combiner],
       annotations: getAnnotations(node),
@@ -45,7 +45,7 @@ function processNode(node: JSONSchema4): SchemaNode | void {
 
   if (type) {
     const base: IBaseNode = {
-      id: assignId(node),
+      id: generateId(),
       type: node.type || inferType(node),
       validations: getValidations(node),
       annotations: getAnnotations(node),
@@ -59,7 +59,7 @@ function processNode(node: JSONSchema4): SchemaNode | void {
 
   if ('enum' in node) {
     return {
-      id: assignId(node),
+      id: generateId(),
       validations: getValidations(node),
       annotations: getAnnotations(node),
       enum: node.enum,
@@ -68,7 +68,7 @@ function processNode(node: JSONSchema4): SchemaNode | void {
 
   if ('$ref' in node) {
     return {
-      id: assignId(node),
+      id: generateId(),
       $ref: node.$ref,
     } as IRefNode;
   }