fix: generate unique id for each node #57
Merged
+12
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lottamus
approved these changes
Oct 11, 2019
Contributor
lottamus
left a comment
lottamus
left a comment
There was a problem hiding this comment.
Nice, this fixes the issue for me. Thanks!
Collaborator
|
🎉 This PR is included in version 2.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue https://github.com/stoplightio/studio/issues/186
I should have done this earlier, since we don't need seem to
assignIdfor quite some time already.AFAIR this was added in first place since there were a couple of calls made to
assignId, and hence it made sense to map a node with each generate id. We don't do it anymore, so there does not seem to be any point in doing it.@lottamus could you yalc it and see whether everything works as expected?
I did a quick test and nothing seems to be broken at first glance, but would be awesome to get another pair of eyes since JSV is used in a couple of spots.