feat: do not display min/max values for oas formats #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulatulis
approved these changes
Apr 8, 2021
Contributor
paulatulis
left a comment
paulatulis
left a comment
There was a problem hiding this comment.
This works for me, so approving. If anyone else on @stoplightio/void-crew wants to take a look to sanity check me, please do!
Collaborator
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/stoplightio/platform-internal/issues/4350
Initially I wanted to address this directly in
http-spec, but I quickly changed my mind, as this could potentially break certain usages. These 5 formats are OAS-specific, and JSON Schema does not support them, therefore the conversion we do includes correct ranges, so that generic JSON Schema tooling can interpret such a schema correctly.Unfortunately, as a side effect, the values get inserted to the document, and JSV renders them.
The solution I decided to go with is rather simple. Since a format implies the valid ranges, we do not need to show it unless a given value was overridden manually.
To be ported to JST / JSV v4.