fix(rendering): uncaught exception #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
fix/uncaught-error
branch
from
ba7f7b5 to
fc56225
Compare
Contributor
|
oh i guess i should take a look at this. |
billiegoose
approved these changes
Sep 6, 2019
| instanceId, | ||
| error: ex.message, | ||
| nodes: null, | ||
| } as RenderedSchemaErrorMessageData); |
Contributor
There was a problem hiding this comment.
🤢 Think it is time to pull out MagicPortal back into its own repo so we can have some of that goodness here?
One of the nice things about MagicPortal is that it automatically handles errors.
Contributor
Author
There was a problem hiding this comment.
@wmhilton yeah, that would be great
Collaborator
|
🎉 This PR is included in version 2.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49