feat: render deprecated next to general validations #64
Conversation
lottamus
left a comment
lottamus
left a comment
There was a problem hiding this comment.
Looks good! One suggestion to make the "deprecated" text orange. And another to safe stringify the object validation
| } else if (typeof validation === 'object') { | ||
| elem = ( | ||
| <div className="m-1 px-1 bg-gray-2 dark:bg-gray-8 font-bold text-sm rounded" key={index}> | ||
| {'{...}'} |
There was a problem hiding this comment.
Why don't we stringify the validation here too so we can display the properties? Similar to what were doing on L53
There was a problem hiding this comment.
I think the reason we did it in the first place is that the object might be large and therefore the text produced wouldn't be readable.
| } else { | ||
| elem = ( | ||
| <div className="m-1 px-1 bg-gray-2 dark:bg-gray-8 font-bold text-sm rounded" key={index}> | ||
| {JSON.stringify(validation)} |
There was a problem hiding this comment.
Should we safe stringify here?
There was a problem hiding this comment.
I don't know. I'd say no, since you won't be able to recognize strings and numbers, i.e. "1" and 1.
Example:
-
JSON.stringify
- string 2
- number 2
- string 2
-
safe stringify
- string 2
- number 2
- string 2
Co-Authored-By: Chris Lott <chrisnlott@gmail.com>
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Addresses https://github.com/stoplightio/platform-internal/issues/736
Before:
After:
