Skip to content

Add more UI feedback when JSON schema uses anyOf or oneOf #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 5, 2021
Merged

Add more UI feedback when JSON schema uses anyOf or oneOf #170

merged 8 commits into from
Nov 5, 2021

Conversation

@Nezteb
Copy link
Contributor

@Nezteb Nezteb commented Nov 4, 2021 •
edited
Loading

@Nezteb Nezteb requested review from a team and jgreen44 November 4, 2021 00:08
Nezteb
Nezteb commented Nov 4, 2021
View reviewed changes
@P0lip
Copy link
Contributor

P0lip commented Nov 4, 2021

what about anyOf? :D

@Nezteb
Copy link
Contributor Author

Nezteb commented Nov 4, 2021

what about anyOf? :D

Do you mean allOf? 😅

@P0lip
Copy link
Contributor

P0lip commented Nov 4, 2021

nah, there are 3 compound keywords - oneOf, anyOf, and allOf :D

@Nezteb
Copy link
Contributor Author

Nezteb commented Nov 4, 2021

nah, there are 3 compound keywords - oneOf, anyOf, and allOf :D

I took care of anyOf and oneOf (allOf wasn't listed in the ticket, I assume because it's... self-explanatory?), or did I miss something?

@P0lip
Copy link
Contributor

P0lip commented Nov 4, 2021

ah fuck, I'm blind, yes. You're right. I read anyOf as allOf.

P0lip
P0lip reviewed Nov 4, 2021
View reviewed changes
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
You may want to use combiners tho if it happens to be yielding the results you expect.

P0lip
P0lip approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just either remove anyOfOrOneOf fn or make use of it if needed

@P0lip
Copy link
Contributor

P0lip commented Nov 4, 2021

@Nezteb you got to update snapshots :D

@Nezteb Nezteb merged commit 49e7a20 into master Nov 5, 2021
@Nezteb Nezteb deleted the anyof-oneof-ui-improvement branch November 5, 2021 18:55
@Nezteb Nezteb mentioned this pull request Nov 9, 2021
Merged
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@P0lip P0lip P0lip approved these changes

@jgreen44 jgreen44 jgreen44 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nezteb @P0lip @stoplight-bot @jgreen44