refactor: pass nodes to rowRendererRight #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lag-of-death
requested review from
P0lip,
chris-miaskowski and
mallachari
and removed request for
P0lip
P0lip
reviewed
Jul 15, 2019
Contributor
P0lip
left a comment
P0lip
left a comment
There was a problem hiding this comment.
Keep in mind rowRendererRight is about to be nuked. #40 - going to finish this today and hopefully it gets merged very soon.
I suggest closing this PR and staying with yalc'ed version in Studio to avoid triggering yet another release
lag-of-death
deleted the
refactor/stu-413-access-nodes-in-row-renderer-right
branch
|
@P0lip @lag-of-death |
Author
|
@chris-miaskowski, I think that's more for @P0lip to say actually since he's working on #40. Thanks for keeping me in the loop |
Contributor
Yeah, I can expose nodes somehow, if needed. |
Author
|
@P0lip, yeah, it is needed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives more control to
rowRendererRight. Thanks to this change, it is now possible to compare the current node with the rest of the nodes that JSV has access to.