Feature: Validate conflicting autoLogin and verifyEmail flags #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+100 awesome fix |
There was a problem hiding this comment.
Is this change intentional? That config.web.changePassword.enabled is not set to whatever config.web.forgotPassword.enabled is set to anymore?
There was a problem hiding this comment.
No it is not. Thanks for noticing! Will fix that :)
There was a problem hiding this comment.
I fixed it for you, and I added some tests for it too :) Please review!
|
@timothyej Looks good. Let's merge this! :) |
timothyej
pushed a commit
that referenced
this pull request
Jan 13, 2016
Feature: Validate conflicting autoLogin and verifyEmail flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates that auto login and email verification features aren't enabled at the same time.
Closes #1